-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-updates - major updates - 2023-09-15 (python3: 3.10 -> 3.11) #251878
Conversation
Running with low build shares: https://hydra.nixos.org/eval/1798880 |
22fc795
to
f126a5c
Compare
7f0072c
to
83a1f94
Compare
I suspect ac85b30
Proposed the change as: #257806 |
@@ -10,11 +10,12 @@ | |||
|
|||
buildPythonPackage rec { | |||
pname = "clickhouse-cli"; | |||
version = "0.3.8"; | |||
version = "0.3.9"; | |||
format = "pyproject"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It no longer works:
$ clickhouse-cli
Traceback (most recent call last):
File "/Users/ivan/.nix-profile/lib/python3.11/importlib/metadata/__init__.py", line 563, in from_name
return next(cls.discover(name=name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
StopIteration
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/ivan/projects/clickhouse-cli-venv/venv/bin/clickhouse-cli", line 33, in <module>
sys.exit(load_entry_point('clickhouse-cli==0.3.8', 'console_scripts', 'clickhouse-cli')())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ivan/projects/clickhouse-cli-venv/venv/bin/clickhouse-cli", line 22, in importlib_load_entry_point
for entry_point in distribution(dist_name).entry_points
^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ivan/.nix-profile/lib/python3.11/importlib/metadata/__init__.py", line 981, in distribution
return Distribution.from_name(distribution_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ivan/.nix-profile/lib/python3.11/importlib/metadata/__init__.py", line 565, in from_name
raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for clickhouse-cli
It also didn't work before due to sqlalchemy (hatarist/clickhouse-cli#50), but it failed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your report.
Unfortunately, we cannot check that all packages are working correctly.
Would you please either fix the packages or if necessary, revert and submit a PR? Feel free to ping me on that.
Also, I would appreciate it if you would consider adding a test, which will help us notice the breakage more quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using some overlay as workaournd
{ channels, ... }:
final: prev: {
clickhouse-cli = channels.unstable.python311Packages.clickhouse-cli.override {
sqlparse = channels.unstable.python311Packages.sqlparse.overridePythonAttrs (oldAttrs: {
src = prev.fetchPypi {
pname = "sqlparse";
version = "0.4.3";
hash = "sha256-acqASEa7EU0uw4DkNgqKNA24PwzPOvzusUBN8Cj1cmg=";
};
nativeBuildInputs = [
prev.python311Packages.flit-core
prev.python311Packages.setuptools
prev.installShellFiles
];
});
};
}
|
Was broken since the Python update from NixOS#251878 This should fix the apfelgrid and applgrid builds, not tested yet
Description of changes
Updates the default python version to 3.11, while keeping 3.10 around until after the NixOS 23.11 release.
This is #249731 on python-updates.