Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some more issues on staging-next related to Python bootstrap changes #251240

Merged
merged 15 commits into from
Aug 25, 2023
Merged

Fix some more issues on staging-next related to Python bootstrap changes #251240

merged 15 commits into from
Aug 25, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 24, 2023

Description of changes

More fixes related to #248866 targeting staging-next (#250778).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 24, 2023
Closed
ChrisPattison
ChrisPattison reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@ChrisPattison ChrisPattison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes generally look good to me. What is going on with the pyairvisual networking?

Unfortunately, I didn't get time to run nixpkgs-review fully, but it seems like there are some failures in fe25519. Are they new?

pkgs/development/python-modules/proxy-py/default.nix Show resolved Hide resolved
pkgs/development/python-modules/pyairvisual/default.nix Show resolved Hide resolved
sternenseemann
sternenseemann reviewed Aug 25, 2023
View reviewed changes
pkgs/development/python-modules/pypandoc/default.nix
@@ -30,6 +32,10 @@ buildPythonPackage rec {
./skip-tests.patch
];

nativeBuildInputs = [
poetry-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't use poetry during the build, it seems silly to depend on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml build uses poetry-core instead of setuptools (defined on these lines). I chose to switch to it because the old setuptools build has some unnecessary dependencies (such as pip) in its setup_requires section. I'm not too sure why there are still two different ways to build the package.

tjni added 14 commits August 24, 2023 17:41
@tjni
python310Packages.fountains: relax setuptools dependency
98c78f0
@tjni
python310Packages.mip: add missing build dependencies
2256a54
@tjni
python310Packages.proxy-py: remove setuptools-scm-git-archive dependency
b4c7f18
@tjni
python310Packages.pyairvisual: clean up build dependencies
92fff4d
@tjni
python310Packages.pypandoc: switch to pyproject build
29d7fe9
@tjni
python310Packages.pytrends: add missing build dependencies
70b193f
@tjni
python310Packages.stim: relax pybind11 and add build dependencies
658da3a
@tjni
python310Packages.fe25519: relax setuptools dependency
c8e00c0
@tjni
python310Packages.ge25519: relax setuptools dependency
0989dca
@tjni
python310Packages.gpytorch: integrate setuptools-scm build dependency
4038550
@tjni
python310Packages.reproject: add missing build dependencies and relax…
f3cd678 
… constraints
@tjni
python310Packages.pymilvus: add missing build dependencies
9dbcb6b
@tjni
python310Packages.pint-pandas: add missing build dependencies
ab961ca
@tjni
python310Packages.drms: add missing build dependencies
c278171
@tjni
Copy link
Contributor Author

tjni commented Aug 25, 2023

Unfortunately, I didn't get time to run nixpkgs-review fully, but it seems like there are some failures in fe25519. Are they new?

It is new and hidden behind the fountains failure. Great catch. I found a few more packages that need similar changes and updated the PR.

@tjni
Copy link
Contributor Author

tjni commented Aug 25, 2023

@ofborg build python310Packages.fountains python311Packages.fountains
@ofborg build python310Packages.mip python311Packages.mip
@ofborg build python310Packages.proxy-py python311Packages.proxy-py
@ofborg build python310Packages.pyairvisual python311Packages.pyairvisual
@ofborg build python310Packages.pypandoc python311Packages.pypandoc
@ofborg build python310Packages.pytrends python311Packages.pytrends
@ofborg build python310Packages.stim python311Packages.stim
@ofborg build python310Packages.fe25519 python311Packages.fe25519
@ofborg build python310Packages.ge25519 python311Packages.ge25519
@ofborg build python310Packages.gpytorch python311Packages.gpytorch
@ofborg build python310Packages.reproject python311Packages.reproject
@ofborg build python310Packages.pymilvus python311Packages.pymilvus
@ofborg build python310Packages.pint-pandas python311Packages.pint-pandas
@ofborg build python310Packages.drms python311Packages.drms

@tjni
Copy link
Contributor Author

tjni commented Aug 25, 2023

I believe that the stim error is an existing one.

nessdoor
nessdoor approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@nessdoor nessdoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as the Python-MIP side goes.

Happy to see movement in the Python packaging space!

@figsoda figsoda added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 25, 2023
@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 251240 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • chatgpt-retrieval-plugin
  • chatgpt-retrieval-plugin.dist
  • python310Packages.sunpy
  • python310Packages.sunpy.dist
  • python311Packages.sunpy
  • python311Packages.sunpy.dist
10 packages failed to build:
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python310Packages.stim
  • python310Packages.stim.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist
77 packages built:
  • apostrophe
  • home-assistant-component-tests.airvisual
  • home-assistant-component-tests.airvisual_pro
  • python310Packages.ax
  • python310Packages.ax.dist
  • python310Packages.botorch
  • python310Packages.botorch.dist
  • python310Packages.drms
  • python310Packages.drms.dist
  • python310Packages.fe25519
  • python310Packages.fe25519.dist
  • python310Packages.fountains
  • python310Packages.fountains.dist
  • python310Packages.ge25519
  • python310Packages.ge25519.dist
  • python310Packages.gpytorch
  • python310Packages.gpytorch.dist
  • python310Packages.mip
  • python310Packages.mip.dist
  • python310Packages.osmnx
  • python310Packages.osmnx.dist
  • python310Packages.pint-pandas
  • python310Packages.pint-pandas.dist
  • python310Packages.proxy-py
  • python310Packages.proxy-py.dist
  • python310Packages.pyairvisual
  • python310Packages.pyairvisual.dist
  • python310Packages.pymilvus
  • python310Packages.pymilvus.dist
  • python310Packages.pypandoc
  • python310Packages.pypandoc.dist
  • python310Packages.pytrends
  • python310Packages.pytrends.dist
  • python310Packages.rasterio
  • python310Packages.rasterio.dist
  • python310Packages.reproject
  • python310Packages.reproject.dist
  • python310Packages.unstructured
  • python310Packages.unstructured.dist
  • python311Packages.ax
  • python311Packages.ax.dist
  • python311Packages.botorch
  • python311Packages.botorch.dist
  • python311Packages.drms
  • python311Packages.drms.dist
  • python311Packages.fe25519
  • python311Packages.fe25519.dist
  • python311Packages.fountains
  • python311Packages.fountains.dist
  • python311Packages.ge25519
  • python311Packages.ge25519.dist
  • python311Packages.gpytorch
  • python311Packages.gpytorch.dist
  • python311Packages.mip
  • python311Packages.mip.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.pint-pandas
  • python311Packages.pint-pandas.dist
  • python311Packages.proxy-py
  • python311Packages.proxy-py.dist
  • python311Packages.pyairvisual
  • python311Packages.pyairvisual.dist
  • python311Packages.pymilvus
  • python311Packages.pymilvus.dist
  • python311Packages.pypandoc
  • python311Packages.pypandoc.dist
  • python311Packages.pytrends
  • python311Packages.pytrends.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.reproject
  • python311Packages.reproject.dist
  • python311Packages.unstructured
  • python311Packages.unstructured.dist
  • wayback-machine-archiver
  • wayback-machine-archiver.dist

@happysalada happysalada merged commit f691c7e into NixOS:staging-next Aug 25, 2023
@tjni tjni deleted the pypa-fix-issues branch August 26, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessdoor nessdoor nessdoor approved these changes

@fabaff fabaff Awaiting requested review from fabaff

@mmahut mmahut Awaiting requested review from mmahut

@bennofs bennofs Awaiting requested review from bennofs

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@ChrisPattison ChrisPattison Awaiting requested review from ChrisPattison

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tjni @happysalada @ChrisPattison @sternenseemann @nessdoor @figsoda