Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some more issues on staging-next related to Python bootstrap changes #251240
Fix some more issues on staging-next related to Python bootstrap changes #251240
Changes from all commits
98c78f0
2256a54
b4c7f18
92fff4d
29d7fe9
70b193f
658da3a
c8e00c0
0989dca
4038550
f3cd678
9dbcb6b
ab961ca
c278171
aa56754
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we don't use poetry during the build, it seems silly to depend on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pyproject.toml
build uses poetry-core instead of setuptools (defined on these lines). I chose to switch to it because the old setuptools build has some unnecessary dependencies (such as pip) in its setup_requires section. I'm not too sure why there are still two different ways to build the package.