crudini: 0.9.3 -> 0.9.4 #252185
Merged
crudini: 0.9.3 -> 0.9.4 #252185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can I trouble you to add |
peterhoeg
reviewed
Aug 29, 2023
pkgs/tools/misc/crudini/default.nix
Outdated
| pushd tests >/dev/null | ||
| bash ./test.sh | ||
| popd >/dev/null | ||
| cd tests && ./test.sh |
There was a problem hiding this comment.
we should do && cd .. afterwards just in case any of the subsequent phases for whatever reason assumes as certain working dir.
There was a problem hiding this comment.
I see now why the pushd and popd were there. I restored them.
Done, thank you for the quick review! |
|
Upstream added the missing INSTALL file, so I pulled in the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests fail on Python 3.11 due to
pipesbeing deprecated. This was fixed in crudini 0.9.4 by pixelb/crudini@e165094.https://github.com/pixelb/crudini/releases/tag/0.9.4
Discovered when testing #251878.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)