-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chia: 1.7.0 -> 2.0.1 #252913
chia: 1.7.0 -> 2.0.1 #252913
Conversation
I think the python tooling is not checking dependencies... |
Just curious what the status on this is, let me know if there's anyway I can help! Is it possible we can add an option for the electron gui app to this package or should we add it in a new separate package? |
Hey, so, what I usually do is copy over the (minimum required subset of) derivations I have in |
812a03e
to
e3bdf75
Compare
I'm not a package maintainer, however I'll mention that before Nix had Chia, I wrote a derivation for personal use. The GUI is both more difficult to package and maintain, as well as having more dependencies many people would not want to pull in (e.g. if they are running Chia on a server, raspberry pi, headless nodes in general.) (cough electron) It would be great to have the GUI in nixpkgs. I would say definitely a seperate package. I'd love to help with Chia too, I've been a Chia supporter since the mainnet launch day. I don't currently know any of the best practices or style rules for nixpkgs, and couldn't currently commit to being a maintainer even if I was more familiar though. btw it appears trivial to tweak this merge to be 2.1.2 instead of 2.0.1 |
|
||
meta = with lib; { | ||
homepage = "https://github.com/Chia-Network/bladebit"; | ||
description = "BladeBit - Fast Chia (XCH) k32-only Plotter"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "BladeBit - Fast Chia (XCH) k32-only Plotter"; | |
description = "Fast Chia (XCH) k32-only Plotter"; |
https://nixos.org/manual/nixpkgs/unstable/#var-meta-description
meta = with lib; { | ||
homepage = "https://github.com/Chia-Network/bladebit"; | ||
description = "BladeBit - Fast Chia (XCH) k32-only Plotter"; | ||
license = with licenses; [ asl20 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license = with licenses; [ asl20 ]; | |
license = licenses.asl20; |
For a single license, we don't use the list.
https://nixos.org/manual/nixpkgs/unstable/#var-meta-license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this patch?
@@ -64,7 +66,7 @@ let chia = python3Packages.buildPythonApplication rec { | |||
zstd | |||
]; | |||
|
|||
nativeCheckInputs = with python3Packages; [ | |||
checkInputs = with python3Packages; [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,14 +6,14 @@ | |||
|
|||
let chia = python3Packages.buildPythonApplication rec { | |||
pname = "chia"; | |||
version = "1.7.0"; | |||
version = "2.0.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "2.0.1"; | |
version = "2.0.1"; | |
pyproject = true; |
Could you please add pyproject = true
?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters
@@ -13,24 +13,24 @@ | |||
|
|||
buildPythonPackage rec { | |||
pname = "blspy"; | |||
version = "1.0.16"; | |||
version = "2.0.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "2.0.2"; | |
version = "2.0.2"; | |
pyproject = true; | |
buildPythonPackage rec { | ||
pname = "chia-rs"; | ||
version = "0.2.0"; | ||
version = "0.2.10"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "0.2.10"; | |
version = "0.2.10"; | |
pyproject = true; |
@@ -39,8 +39,9 @@ buildPythonPackage rec { | |||
touch wheel/Cargo.lock | |||
''; | |||
|
|||
nativeCheckInputs = [ | |||
checkInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkInputs = [ | |
nativeCheckInputs = [ |
@@ -16,21 +18,27 @@ | |||
|
|||
buildPythonPackage rec { | |||
pname = "chiapos"; | |||
version = "1.0.11"; | |||
version = "2.0.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "2.0.2"; | |
version = "2.0.2"; | |
pyproject = true; | |
closed in favor of #270254 |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)