-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chia: drop #270254
chia: drop #270254
Conversation
weird I thought I forked the latest master |
6096f25
to
45d8cac
Compare
Could you add tombstones to |
bcf0898
to
674b095
Compare
674b095
to
517d5ab
Compare
ok this is ready. It should pass ofborg but I will check tomorrow whether I messed up something. |
Thank you very much for the clean-up! Hopefully at some point in the future upstream will fix things to be more distro-friendly and we can maybe get those packages back in nixpkgs without them being a maintenance nightmare :-) |
Hi @meebey, nice to know someone else is using this. So in short, what happens with chia is a mix of different things. Most often, it depends on newer package versions that the ones in I have been working on |
In the case of #270155 which triggered this discussion of removal, it's also that upstream doesn't provide a working reproducible setup to build Python wheels - requiring nixpkgs to carry some large-ish patches that regularly break and require upkeep. |
Chia was pulled from the nixpkgs tree (NixOS/nixpkgs#270254) and the alternative provided, `chia.nix`, still hasn't landed v2 (https://github.com/0xbbjubjub/chia.nix). Switch to a more stable container release even if it's heavier than a nixpkg. Hopefully at some point in the future the Nix build will stabilise. Latest docker package selected from https://github.com/Chia-Network/chia-docker/pkgs/container/chia - electing to do update this manually for determinism.
Description of changes
Remove the
chia
derivation and its exclusive references, and disband the chia team.For the record, these packages always required a ton of hacks and tricks to maintain in-tree because of very specific dependencies and other idiosyncrasies and I don't have the resources to do that anymore. It may work better out-of-tree in something like chia.nix.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Priorities
Add a 👍 reaction to pull requests you find important.