Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chia: drop #270254

Merged
merged 1 commit into from
Nov 30, 2023
Merged

chia: drop #270254

merged 1 commit into from
Nov 30, 2023

Conversation

bbjubjub2494
Copy link
Member

Description of changes

Remove the chia derivation and its exclusive references, and disband the chia team.

For the record, these packages always required a ton of hacks and tricks to maintain in-tree because of very specific dependencies and other idiosyncrasies and I don't have the resources to do that anymore. It may work better out-of-tree in something like chia.nix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@bbjubjub2494
Copy link
Member Author

weird I thought I forked the latest master

@delroth
Copy link
Contributor

delroth commented Nov 26, 2023

Could you add tombstones to pkgs/top-level/aliases.nix for the removed packages (as well as pkgs/top-level/python-aliases.nix for the Python packages)?

@bbjubjub2494 bbjubjub2494 force-pushed the chia-drop branch 4 times, most recently from bcf0898 to 674b095 Compare November 29, 2023 19:56
@bbjubjub2494
Copy link
Member Author

ok this is ready. It should pass ofborg but I will check tomorrow whether I messed up something.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 30, 2023
@bbjubjub2494 bbjubjub2494 requested a review from delroth November 30, 2023 07:23
@delroth
Copy link
Contributor

delroth commented Nov 30, 2023

Thank you very much for the clean-up! Hopefully at some point in the future upstream will fix things to be more distro-friendly and we can maybe get those packages back in nixpkgs without them being a maintenance nightmare :-)

@delroth delroth merged commit f5c27c6 into NixOS:master Nov 30, 2023
8 checks passed
@bbjubjub2494 bbjubjub2494 deleted the chia-drop branch November 30, 2023 15:50
@meebey
Copy link
Contributor

meebey commented Dec 3, 2023

Today I wanted to bump my chia node and noticed the package was removed. @delroth @lourkeur any specific packaging pain that led to the removal? The feedback might help upstream to be less painful in the future (I will pass the message on).

@bbjubjub2494
Copy link
Member Author

Hi @meebey, nice to know someone else is using this. So in short, what happens with chia is a mix of different things. Most often, it depends on newer package versions that the ones in master, so I would forward-port them, but that risks breaking something else. There's also always something unexpected that I have to go and debug. I don't think upstream can do much about it because their development style of bumping dependencies very often and having a lot of them is justified, and Nixpkgs's approach of manually and slowly bumping python modules is also justified, they are just incompatible.

I have been working on chia.nix as I said, and if the trust assumption is ok with you, you can get 1.8.2 or 1.8.3-rc1 right now, and more recent versions soon (tm)

@delroth
Copy link
Contributor

delroth commented Dec 3, 2023

In the case of #270155 which triggered this discussion of removal, it's also that upstream doesn't provide a working reproducible setup to build Python wheels - requiring nixpkgs to carry some large-ish patches that regularly break and require upkeep.

@onemoresuza onemoresuza mentioned this pull request Dec 13, 2023
13 tasks
JakeHillion added a commit to JakeHillion/nixos that referenced this pull request Feb 8, 2024
Chia was pulled from the nixpkgs tree
(NixOS/nixpkgs#270254) and the alternative
provided, `chia.nix`, still hasn't landed v2
(https://github.com/0xbbjubjub/chia.nix).

Switch to a more stable container release even if it's heavier than a
nixpkg. Hopefully at some point in the future the Nix build will
stabilise.

Latest docker package selected from https://github.com/Chia-Network/chia-docker/pkgs/container/chia - electing to do update this manually for determinism.
@abueide abueide mentioned this pull request Feb 13, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants