Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_11: remove #264250

Merged
merged 5 commits into from
Oct 31, 2023
Merged

postgresql_11: remove #264250

merged 5 commits into from
Oct 31, 2023

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 29, 2023

Description of changes

This version will stop receiving fixes as of Nov 09 2023, so it needs to be removed before 23.11.

cc @NixOS/nixos-release-managers

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added this to the 23.11 milestone Oct 29, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 29, 2023
@Ma27 Ma27 mentioned this pull request Oct 29, 2023
Merged
13 tasks
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Oct 29, 2023
@Ma27
postgresql_jit: fix build
8fbd381 
Failing Hydra build: https://hydra.nixos.org/build/239477682/nixlog/1

This got fixed upstream already in the release branches, applying the
patches here solves the issue.

This skips v11 since there's no patch available and it will be dropped
soon anyways[1].

[1] NixOS#264250
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 29, 2023
@natsukium
Copy link
Member

@ofborg eval

the-furry-hubofeverything
the-furry-hubofeverything reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@the-furry-hubofeverything the-furry-hubofeverything left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an entry be added in pkgs/top-level/aliases.nix?

@natsukium The eval is failing because #264290 isn't included, needs rebase

@the-furry-hubofeverything
Copy link
Contributor

What about postgresql_10?

@Ma27
Copy link
Member Author

Ma27 commented Oct 30, 2023

Should an entry be added in pkgs/top-level/aliases.nix?

This wasn't done in the past and I don't see a reason to do this (assuming you mean an alias like postgresql_11 = throw "...";): AFAIK this mostly happens when an entire package is thrown out or when a major version is dropped not only on unstable, but everywhere including stable (one example for this is the Linux kernel).

In this case it's mostly a matter of reading the release notes or getting an error when evaluating your NixOS deployment which should be sufficient IMHO.

What about postgresql_10?

Assuming you mean that this isn't in the package = ... expression: to be frank, I don't know. But if I had to guess there was no stateVersion of NixOS which defaulted to postgresql_10, so no reason to have it here. Seems out of scope to me though (unless I'm missing something).

Ma27 added 2 commits October 30, 2023 10:41
@Ma27
postgresql_11: remove
1220a4d 
As described in the release lifecycle docs from postgresql[1], v11 will
stop receiving fixes as of Nov 9 2023. This means it's EOL throughout
the entire lifetime of 23.11, so let's drop it now.

A lot of examples are also referencing postgresql_11. Where it's
sensible, use postgresql_15 as example now to avoid confusion.

This is also handy because the LLVM 16 fix for postgresql is not
available for postgresql 11 ;-)

[1] https://www.postgresql.org/support/versioning/
@Ma27
glom: provide bin dir of postgresql
71ece62 
By default `pg_config --bindir` is executed during configure phase to
get the bin directory containing all the postgres executables used by
glom.

This seems wrong given that the same postgresql_15 package will be
executed on build and on the final host platform which is not
necessarily the same. To avoid that, specify the bin dir manually via
the corresponding configure option.
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 30, 2023
marsam
marsam approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Would you mind removing pipelinedb.nix and other references of "11" in the extensions?

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 30, 2023
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 30, 2023
@Ma27
Copy link
Member Author

Ma27 commented Oct 30, 2023

@marsam done :)

@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 30, 2023
@Ma27
postgresql: remove pipelinedb extension
945cdad 
This one is apparently abandoned by upstream and only supported
postgresql_11 which is about to be dropped from nixpkgs.
@Ma27
Copy link
Member Author

Ma27 commented Oct 30, 2023

Huh just realized that there's still a reference left in nixos/tests/postgresql.nix. Will fix that as well.

@Ma27
nixos/postgresql: remove postgresql_11-backup-all test
279cecf 
I don't really understand why this is only for a single version, so I
figured I'd just add this to the test matrix to also cover this
test-case for each major. Now, there's also one thing less to take care of
when removing old postgresql versions.
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Oct 30, 2023
marsam
marsam approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marsam marsam merged commit 1122fb5 into NixOS:master Oct 31, 2023
@Ma27 Ma27 deleted the rm-postgres-11 branch October 31, 2023 07:10
@rvl
Copy link
Contributor

rvl commented Dec 5, 2023

I was upgrading my configuration from 23.05 to 23.11 and got this error:

error: postgresql_11 was removed, please upgrade your postgresql version.

It was confusing because I have never set services.postgresql.package = pkgs.postgresql_11. Turns out it was implicitly set through system.stateVersion = "20.03".

@Ma27, I suggest changing the error message to something like this:

mkThrow = ver: throw ''
  Your setting of system.stateVersion = "${config.system.stateVersion}"
  implies using pkgs.postgresql_${ver}.
  However, this version was removed. Please upgrade your postgresql version by setting
  services.postgresql.package = pkgs.postgresql_13
  (or any later version).
'';

@Ma27
Copy link
Member Author

Ma27 commented Dec 5, 2023

Feel free to file a PR for that.

@rvl
Copy link
Contributor

rvl commented Dec 8, 2023

PR #272834 filed, @Ma27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-furry-hubofeverything the-furry-hubofeverything the-furry-hubofeverything left review comments

@marsam marsam marsam approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@figsoda figsoda figsoda approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
23.11
Development

Successfully merging this pull request may close these issues.
8 participants
@Ma27 @natsukium @the-furry-hubofeverything @rvl @marsam @RaitoBezarius @figsoda @delroth