Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhugetlbfs: make meta.badPlatforms flat; fix ofborg eval error #264290

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

natsukium
Copy link
Member

This change fixes ofborg eval error

I tested it with following command.

curl -o outpaths.nix https://raw.githubusercontent.com/NixOS/ofborg/released/ofborg/src/outpaths.nix
GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This change fixes ofborg eval error
@natsukium natsukium requested a review from K900 October 30, 2023 02:51
@natsukium natsukium changed the title libhugetlbfs: make meta.badPlatforms flat libhugetlbfs: make meta.badPlatforms flat; fix ofborg eval error Oct 30, 2023
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the currently broken ofborg meta check for me. Instructions in pr are from https://github.com/NixOS/ofborg/?tab=readme-ov-file#running-meta-checks-locally

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 30, 2023
@adamcstephens adamcstephens mentioned this pull request Oct 30, 2023
13 tasks
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 30, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 30, 2023
@zowoq zowoq merged commit 55af7f3 into NixOS:master Oct 30, 2023
@natsukium natsukium deleted the fix-ofborg-eval branch October 30, 2023 05:24
@arcnmx arcnmx mentioned this pull request Oct 30, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants