Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.qcodes-loop: remove patch #264308

Merged
merged 1 commit into from
Oct 31, 2023
Merged

python311Packages.qcodes-loop: remove patch #264308

merged 1 commit into from
Oct 31, 2023

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Oct 30, 2023

Description of changes

Fix build (https://hydra.nixos.org/build/239412543). Failed after #251878

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
python311Packages.qcodes-loop: remove patch
9909fe5 
- add changelog to meta
- enable all tests
@fabaff fabaff added the 0.kind: build failure A package fails to build label Oct 30, 2023
@fabaff fabaff mentioned this pull request Oct 30, 2023
Merged
13 tasks
@fabaff
Copy link
Member Author

fabaff commented Oct 30, 2023

Result of nixpkgs-review pr 264308 run on x86_64-linux 1

4 packages built:
  • python310Packages.qcodes-loop
  • python310Packages.qcodes-loop.dist
  • python311Packages.qcodes-loop
  • python311Packages.qcodes-loop.dist

@fabaff fabaff merged commit 468474b into NixOS:master Oct 31, 2023
@fabaff fabaff deleted the qcodes-loop-fix branch October 31, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabaff