Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hdbscan: Fix build #269435

Closed
wants to merge 1 commit into from

Conversation

MaxwellDupre
Copy link
Contributor

Description of changes

hdbscan fails on Hydra hence have amended and has built successfully locally.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@MaxwellDupre MaxwellDupre self-assigned this Nov 23, 2023
@MaxwellDupre MaxwellDupre added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign and removed 6.topic: python labels Nov 23, 2023
@AndersonTorres AndersonTorres marked this pull request as draft November 23, 2023 14:04
@AndersonTorres
Copy link
Member

Reword.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 23, 2023
@MaxwellDupre MaxwellDupre changed the title Update hdbscan.8.33 python3Packages.hdbscan 8.33 Update Nov 24, 2023
@MaxwellDupre MaxwellDupre marked this pull request as ready for review November 24, 2023 11:41
@risicle
Copy link
Contributor

risicle commented Nov 25, 2023

The commit message should be e.g. python3Packages.hdbscan: fix build

@MaxwellDupre MaxwellDupre changed the title python3Packages.hdbscan 8.33 Update python3Packages.hdbscan: Fix build Nov 27, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#270506 already removed the patch. the other changes look good. tho, shouldn't there be a merge conflict?

Result of nixpkgs-review pr 269435 run on x86_64-linux 1

4 packages built:
  • python310Packages.hdbscan
  • python310Packages.hdbscan.dist
  • python311Packages.hdbscan
  • python311Packages.hdbscan.dist

Result of nixpkgs-review pr 269435 run on x86_64-darwin 1

4 packages built:
  • python310Packages.hdbscan
  • python310Packages.hdbscan.dist
  • python311Packages.hdbscan
  • python311Packages.hdbscan.dist

@ghost ghost self-requested a review December 1, 2023 07:27
Comment on lines +27 to +28
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ];
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ];
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ];
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools oldest-supported-numpy ];
propagatedBuildInputs = [ numpy scipy scikit-learn joblib six ];

missed this. oldest-supported-numpy is a build input (i think it just resolves to numpy).

@ghost
Copy link

ghost commented Dec 1, 2023

@ofborg build python311Packages.hdbscan

the commit message needs to be changed, as noted above, to python311Packages.hdbscan: fix build this will allow the CI to fire off builds to test your change. change the name by amending the last commit message: git commit --amend then push the changes git push --force-with-lease. this is mentioned in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-tos

@ghost
Copy link

ghost commented Jan 16, 2024

superseded by #270506

@ghost ghost closed this Jan 16, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants