-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.hdbscan: Fix build #269435
Conversation
Reword. |
The commit message should be e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#270506 already removed the patch. the other changes look good. tho, shouldn't there be a merge conflict?
Result of nixpkgs-review pr 269435
run on x86_64-linux 1
4 packages built:
- python310Packages.hdbscan
- python310Packages.hdbscan.dist
- python311Packages.hdbscan
- python311Packages.hdbscan.dist
Result of nixpkgs-review pr 269435
run on x86_64-darwin 1
4 packages built:
- python310Packages.hdbscan
- python310Packages.hdbscan.dist
- python311Packages.hdbscan
- python311Packages.hdbscan.dist
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ]; | ||
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ]; | |
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ]; | |
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools oldest-supported-numpy ]; | |
propagatedBuildInputs = [ numpy scipy scikit-learn joblib six ]; |
missed this. oldest-supported-numpy is a build input (i think it just resolves to numpy).
@ofborg build python311Packages.hdbscan the commit message needs to be changed, as noted above, to |
superseded by #270506 |
Description of changes
hdbscan fails on Hydra hence have amended and has built successfully locally.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Priorities
Add a 👍 reaction to pull requests you find important.