Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.hdbscan: Fix build #269435

Closed
wants to merge 1 commit into from
Closed

python3Packages.hdbscan: Fix build #269435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions pkgs/development/python-modules/hdbscan/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,30 @@
, buildPythonPackage
, fetchpatch
, cython
, numpy
, oldest-supported-numpy
, pytestCheckHook
, scipy
, scikit-learn
, fetchPypi
, joblib
, setuptools
, six
, pythonRelaxDepsHook
}:

buildPythonPackage rec {
pname = "hdbscan";
version = "0.8.33";
pyproject = true;

src = fetchPypi {
inherit pname version;
hash = "sha256-V/q8Xw5F9I0kB7NccxGSq8iWN2QR/n5LuDb/oD04+Q0=";
};
patches = [
# should be included in next release
(fetchpatch {
name = "joblib-1.2.0-compat.patch";
url = "https://github.com/scikit-learn-contrib/hdbscan/commit/d829c639923f6866e1917e46ddbde45b513913f3.patch";
excludes = [
"docs/basic_hdbscan.rst"
"docs/how_hdbscan_works.rst"
];
hash = "sha256-t0D4OsHEcMwmBZM8Mk1N0uAKi6ra+TOzEks9/efsvWI=";
})
];

pythonRemoveDeps = [ "cython" ];
nativeBuildInputs = [ pythonRelaxDepsHook cython ];
propagatedBuildInputs = [ numpy scipy scikit-learn joblib six ];
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ];
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ];
Comment on lines +27 to +28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools ];
propagatedBuildInputs = [ oldest-supported-numpy scipy scikit-learn joblib six ];
nativeBuildInputs = [ pythonRelaxDepsHook cython setuptools oldest-supported-numpy ];
propagatedBuildInputs = [ numpy scipy scikit-learn joblib six ];

missed this. oldest-supported-numpy is a build input (i think it just resolves to numpy).

preCheck = ''
cd hdbscan/tests
rm __init__.py
Expand All @@ -59,5 +49,6 @@ buildPythonPackage rec {
description = "Hierarchical Density-Based Spatial Clustering of Applications with Noise, a clustering algorithm with a scikit-learn compatible API";
homepage = "https://github.com/scikit-learn-contrib/hdbscan";
license = licenses.bsd3;
maintainers = with maintainers; [ mikecm ];
};
}