python311Packages.astropy-healpix: upstream patch to fix darwin build #270027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
0.kind: ZHF Fixes
upstream patch adds const to arguments so the function definition matches the function pointer prototype. remove patch on next version update
ghost
mentioned this pull request
13 tasks
ghost
requested a review
from 
ofborg
bot
added
6.topic: darwin
smaret
approved these changes
Nov 27, 2023
smaret
added
the
12.approved-by: package-maintainer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1262 |
|
@NixOS/nixos-release-managers |
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream patch adds const to arguments so the function definition matches the function pointer prototype.
remove patch on next version update
ZHF: #265948
https://hydra.nixos.org/build/241694951
with #270042 merged all packages build on darwin
Result of
nixpkgs-review pr 270027run on x86_64-darwin 124 packages built:
Result of
nixpkgs-reviewrun on x86_64-linux 124 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.