Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-23.11] python311Packages.pyregion: 2.1.1 -> 2.2.0; fix darwin build #270511

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[Backport release-23.11] python311Packages.pyregion: 2.1.1 -> 2.2.0; fix darwin build #270511

merged 1 commit into from
Nov 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 27, 2023 •
edited by risicle
Loading

Bot-based backport to release-23.11, triggered by a label in #270042.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@github-actions
python311Packages.pyregion: 2.1.1 -> 2.2.0; fix darwin build
5a61627 
https://github.com/astropy/pyregion/blob/2.2.0/CHANGES.rst

add -Wno-error=int-conversion for clang to not error out on generated
code. (code returns NULL rather than 0). gcc warns but does not error.

(cherry picked from commit 8326361)
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
Merged
13 tasks
@ghost
Copy link

ghost commented Nov 28, 2023

@ofborg eval

@ghost
Copy link

ghost commented Nov 28, 2023

@ofborg build python311Packages.pyregion

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 28, 2023
@ofborg ofborg bot requested a review from smaret November 28, 2023 04:12
@ghost
Copy link

ghost commented Nov 28, 2023

same list of darwin failures as #270042 which will all build once #270027 is merged and backported.

cc @risicle who merged #270042 (thanks!)

Result of nixpkgs-review pr 270511 run on x86_64-linux 1

20 packages built:
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.glueviz
  • python310Packages.glueviz.dist
  • python310Packages.pvextractor
  • python310Packages.pvextractor.dist
  • python310Packages.pyregion
  • python310Packages.pyregion.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python311Packages.pvextractor
  • python311Packages.pvextractor.dist
  • python311Packages.pyregion
  • python311Packages.pyregion.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist

Result of nixpkgs-review pr 270511 run on x86_64-darwin 1

16 packages failed to build:
  • python310Packages.aplpy
  • python310Packages.aplpy.dist
  • python310Packages.glueviz
  • python310Packages.glueviz.dist
  • python310Packages.pvextractor
  • python310Packages.pvextractor.dist
  • python310Packages.spectral-cube
  • python310Packages.spectral-cube.dist
  • python311Packages.aplpy
  • python311Packages.aplpy.dist
  • python311Packages.glueviz
  • python311Packages.glueviz.dist
  • python311Packages.pvextractor
  • python311Packages.pvextractor.dist
  • python311Packages.spectral-cube
  • python311Packages.spectral-cube.dist
4 packages built:
  • python310Packages.pyregion
  • python310Packages.pyregion.dist
  • python311Packages.pyregion
  • python311Packages.pyregion.dist

@ghost
Copy link

ghost commented Nov 29, 2023

#265948

smaret
smaret approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@smaret smaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@smaret smaret added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Nov 29, 2023
@JulienMalka
Copy link
Member

If I understand correctly this has a dependency on #270883, right?

@ghost
Copy link

ghost commented Nov 29, 2023

If I understand correctly this has a dependency on #270883, right?

they are independent but most consumers use both packages, so to fix all the consumers, both commits are needed.

@ghost ghost mentioned this pull request Nov 29, 2023
Merged
1 task
@JulienMalka JulienMalka merged commit c4d1a77 into release-23.11 Nov 29, 2023
14 checks passed
@bjornfor bjornfor deleted the backport-270042-to-release-23.11 branch November 29, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienMalka JulienMalka JulienMalka approved these changes

@smaret smaret smaret approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienMalka @smaret