Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gcc13 include fixes #279904

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Jan 9, 2024

Description of changes

Spotted a few more easy leaf packages while skimming through the breakage versus nixos-unstable.

Meshlab builds & launches but seems a bit wonky, not sure if that's a regression and/or related to my plasma6 wayland session. It is "slightly" out of date anyway so paging @viric to have a look if possible.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jansol jansol mentioned this pull request Jan 9, 2024
@mweinelt mweinelt merged commit fa63c00 into NixOS:staging-next Jan 10, 2024
23 of 24 checks passed
@jansol jansol deleted the more-gcc13-include-fixes branch January 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants