-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor texinfo and update 7.0.3 -> 7.1 #289690
Conversation
00d99d0
to
d7e3704
Compare
ℹ️ texinfo, texinfo.passthru.tests on x86_64-darwin and aarch64-darwin failed due to: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3468 |
d7e3704
to
0137f79
Compare
0137f79
to
ffb21eb
Compare
Friendly ping on this, @AndersonTorres, with a polite request for comments on the "Things I kindly request feedback on" in the initial PR comment/description 🙂 |
ffb21eb
to
f0131c6
Compare
Friendly ping to current reviewers on this 🙂 |
Thanks for merging, @7c6f434c, very, very much appreciated! I thought this PR might never see the light of day 🥲 |
Bisect says 0626ef8
|
I’m also seeing this error building zsh on staging.
|
Thanks for chiming in on this, @reckenrode, any hint is helpful! I'm looking at zsh's |
This email thread on texinfo mailing list might provide some helpful insights. |
For ffmpeg a patch exist ( |
Thanks. I opened #324900 with a fix. |
Does not apply to
|
@reckenrode thanks for the zsh fix, and glad to see it already got merged. Thanks for giving the patch a try, too bad it fails. I'll dig deeper and will report back with any findings. |
A quick update for folks following the conversation here: Feel free to comment, test, double-check the changes proposed in #326249 🙂 |
e6f9072 broke cross-compiling for Raspberry Pi:
Is this a problem to be reported upstream? Or can we fix this ourselves? |
Oh wait, your building texinfo itself and not ffmpeg… 🤔 |
Can you post a link to a complete log, please? |
Sure!
|
Thanks, @jue89, that's helpful I'll have a closer look. I'd like to suggest to attach larger files via drag and drop, as that makes consuming them much easier, or is there another way than just copy and pasting the text? 🙂 |
Could you Also I'm struggling a bit with my own raspberry pi nixos setup (more specifically garbled serial console output), would you be willing to answer a few question and if yes, what would be your preferred means of communications? |
The |
Here you go: config.log |
Sure, I'd love to help you debugging this. |
Indeed! This seems to work! I guess it's time for a follow-up PR? jue@baxxter ~/P/nixpkgs ((3ddf4322))> git diff
diff --git a/pkgs/development/tools/misc/texinfo/common.nix b/pkgs/development/tools/misc/texinfo/common.nix
index 9b5959d40e47..99a5d2858e27 100644
--- a/pkgs/development/tools/misc/texinfo/common.nix
+++ b/pkgs/development/tools/misc/texinfo/common.nix
@@ -100,6 +100,7 @@ stdenv.mkDerivation {
++ optionals crossBuildTools [
"--enable-perl-xs=no"
"TI_AWK=${getBin gawk}/bin/awk"
+ "texinfo_cv_sys_iconv_converts_euc_cn=yes"
]
++ optional stdenv.isSunOS "AWK=${gawk}/bin/awk"; |
Also thanks to you, @reckenrode, for proposing a working fix. 👍 |
ℹ️ This draft PR is my understanding of how the texinfo package could be improved based off @AndersonTorres' comment on #262276 and work on
nv-codec-headers
(see #287918).texinfo 7.0.3 -> 7.1
Diff: http://git.savannah.gnu.org/cgit/texinfo.git/diff/?id=texinfo-7.0.3&id2=texinfo-7.1
Changelog: http://git.savannah.gnu.org/cgit/texinfo.git/tree/ChangeLog?h=texinfo-7.1
TODO
Description of changes
texinfo/4.13a.nix
by usingfinalAttrs
andhash
texinfo/4.13a.nix
intotexinfo/default.nix
(see below) as it shares no common attributes with the other texinfo versions apart frommeta
texinfo/common.nix
by removing top-levelwith lib
, usinghash
, and addingmeta.mainProgram
texinfo/common.nix
by adding missinglibiconv
inputtexinfo/default.nix
andtexinfo6_5
->texinfo_6_5
.all-packages.nix
according to the changes abovetexinfo_7_0
withtexinfo_7_1
texinfo_7_1
Things I kindly request feedback on
meta
attributes?mainProgram
should indeed betexi2any
?texinfo[4567]
names, yet this PR seems also like a good opportunity to either rename or remove them and change all dependent package.If yes, which of the following existing appraoches is then preferred? Ⓐ or Ⓑ?
Ⓐ The following packages reference a texinfo version specific package directly:
texinfo5
, i.e. texinfo 5.2)texinfo6
, i.e. texinfo 6.8)texinfo4
, i.e. texinfo 4.13a)texinfo4
, i.e. texinfo 4.13a)Ⓑ whereas the following packages have a
texinfo
input, which is set to a specific texinfo version inall-packages.nix
:texinfo6
, i.e texinfo 6.8)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.