Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texinfo: set texinfo_cv_sys_iconv_converts_euc_cn=yes when cross comp… #328919

Merged
merged 1 commit into from
Jul 24, 2024
Merged

texinfo: set texinfo_cv_sys_iconv_converts_euc_cn=yes when cross comp… #328919

merged 1 commit into from
Jul 24, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jul 21, 2024

…iling version >= 7.1

Reference: https://lists.openembedded.org/g/openembedded-core/message/197071

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 21, 2024
@afh afh mentioned this pull request Jul 23, 2024
Merged
19 tasks
afh
afh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @NickCao, very much appreciated 💯

jue89
jue89 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jue89 jue89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

nix build github:NickCao/nixpkgs/2ea2276b3032dc1ae8d21d23fd87b1fc5c3f0f66#pkgsCross.raspberryPi.texinfoInteractive successfully builds texinfo.

I verified the binaries to be working by executing them using QEMU.

ACK from my side.

@NickCao NickCao merged commit 59e2616 into NixOS:staging Jul 24, 2024
28 checks passed
@NickCao NickCao deleted the texinfo-cross branch July 24, 2024 23:13
@afh
Copy link
Member

afh commented Jul 25, 2024

Thanks for merging this, @NickCao, very much appreciated! 💯

@brianmcgillion brianmcgillion mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jue89 jue89 jue89 approved these changes

@afh afh afh approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickCao @afh @jue89