nixos/bcachefs: support unlock with clevis in systemd stage 1 #295736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
I'll test this on my device during this week |
|
I tested the change on physical hardware, works for me. |
|
Some of clevis tests are broken currently so I was not able to add the tests so far. |
ElvishJerricco
previously requested changes
Apr 2, 2024
|
Sounds like #300757 will fix the test. Let's add the test in this PR after that's merged. |
JulienMalka
force-pushed
the
bcachefs-clevis-systemd
branch
from
cdaae3d to
5afb7f3
Compare
JulienMalka
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
#300757 has landed, rebased on master and added the two tests.
Tested on local hardware for a week, tests are going through, LGTM.
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the unlock script for bcachefs devices to attempt to use Clevis to unlock, as currently this only works in scripted stage 1.
I tested it on my Framework 13 by using PCR 7 and toggling whether SecureBoot was enabled. With it enabled, I wasn't prompted for my passphrase and booted to my display manager without input. With SecureBoot disabled, the unlock with Clevis failed and I was prompted for my passphrase.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.