nixos/tests/installer: spring cleaning #300757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: nixos
K900
force-pushed
the
installer-tests-unfucking
branch
from
f542bbf to
8a72ec5
Compare
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
JulienMalka
reviewed
Apr 3, 2024
K900
force-pushed
the
installer-tests-unfucking
branch
from
8a72ec5 to
b726cf3
Compare
github-actions
bot
added
8.has: module (update)
ofborg
bot
added
8.has: package (new)
K900
force-pushed
the
installer-tests-unfucking
branch
from
b726cf3 to
79df2ae
Compare
- use normal VM nodes for target, with some extra trickery - rename preBootCommands to postBootCommands to match its actual intent - rename VMs to installer and target, so they're not all called machine - set platforms on non-UEFI tests properly - add missing packages for systemd-boot test - fix initrd secrets leaking into the store and having wrong paths
K900
changed the title
K900
force-pushed
the
installer-tests-unfucking
branch
from
79df2ae to
7b602cf
Compare
|
Finally, all the tests pass (yes, even the ones that didn't before). |
|
Added a pretty ugly but still workaround. |
RaitoBezarius
approved these changes
Apr 5, 2024
roberth
reviewed
Apr 10, 2024
| @@ -34,6 +34,13 @@ in | |||
| Sets the [`meta.broken`](https://nixos.org/manual/nixpkgs/stable/#var-meta-broken) attribute on the [{option}`test`](#test-opt-test) derivation. | |||
| ''; | |||
| }; | |||
| platforms = lib.mkOption { | |||
| type = types.listOf types.raw; | |||
| default = lib.platforms.linux; | |||
There was a problem hiding this comment.
We also support darwin; to be added in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See commit message for up to date details.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.