-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NixOS Integration Tests: Enable again for darwin #303150
NixOS Integration Tests: Enable again for darwin #303150
Conversation
Some tests does not make sense on some architectures, e.g. BIOS only exist on x86_64. |
@RaitoBezarius thank you for the quick merge! EDIT: Sorry @K900 merged, thank you. :)
That is uncontroversial, but this meta field describes the compatibility of the test runner, not the test itself. |
FYI: this broke ofborg's eval:
Revert is in #303187 |
Description of changes
This commit: 7b602cf
...disabled NixOS integration tests from running on macOS, while this is now generally supported thanks to @Gabriella439.
This PR re-enables darwin as a supported platform. I had customers pinging me why tests don't work on macos any longer... Can we please merge this in sensible time?
Generally, i feel like the supported lists of platform does not make sense to be configurable on the test level? the other
meta
options seem fine to have so authors of integration tests can define if they are maintainers, and description etc - but the list of supported systems?Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.