buildMavenPackage: Add overrideMavenAttrs function and buildOffline documentation

[tricktron]

Description of changes

This pr does the following:

• Adds a overrideMavenAttrs function to make it possible to override attributes of the buildMavenPackage function.
• Documents the overrideMavenAttrs function.
• Documents the use case of the buildOffline = true argument for the buildMavenPackage function.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tricktron]

@ofborg build lemminx dbeaver java-language-server h2 scenebuilder schemaspy

[fricklerhandwerk]

Discussed at #ZurichZHF

[tricktron]

@roberth Any idea on how to make this work with finalAttrs?
E.g.

jd-cli.overrideMavenAttrs (finalAttrs: old: rec {
...

[roberth]

@roberth Any idea on how to make this work with finalAttrs? E.g.

jd-cli.overrideMavenAttrs (finalAttrs: old: rec {
...

I'm not 100% sure what it should mean, and while it could be done, the "architecture" - functions composed in sequence, but made overridable - does not make this easy, and requires that the logic to make that work have knowledge about all other relevant overriding functions, such as overrideAttrs or even others introduced via passthru.
For this reason I'm proposing to change the architecture in

• Bring all packaging layers into a single fixpoint #273815

I'm sure you could make it work for limited use cases, e.g. initially not supporting overrideMavenAttrs after overrideAttrs has been called; I just think effort is better spent on solving the root of the problem.

[tricktron]

@roberth @fricklerhandwerk I cleaned up the pr for you guys. Unfortunately, I cannot attend the second ZHF day, so I won't be onsite for more interesting discussions.

[tomodachi94]

This is interesting. I'm generally not opposed to this, but I think the plan should be to eventually remove buildMavenPackage in favor of setup hooks. @NixOS/java: thoughts?

[tomodachi94]

Also, @tricktron and company: It would be awesome to see you in #jvm:nixos.org if you're interested in helping maintain the Nixpkgs Java ecosystem at all 🙂

[tricktron]

This is interesting. I'm generally not opposed to this, but I think the plan should be to eventually remove buildMavenPackage in favor of setup hooks. @NixOS/java: thoughts?

I have discussed the same thing with @wegank today and I agree that setup hooks might be an even better improvement.

So we could first merge that in and setup the switch to setup hooks in a future pr. I am fine with contributing to that too.

What do you think?

[tomodachi94]

What do you think?

I think that would be ideal in this situation. I'll take a look at this in a moment (if I can wrap my head around how overrides work behind the scenes 😉).

[tricktron]

@fricklerhandwerk Could you unblock merging this and/or update your needed points?

[tomodachi94]

Lgtm, thank you 💖 If you're interested in maintaining this package, I encourage you to add yourself to meta.maintainers.

[tricktron]

Lgtm, thank you 💖 If you're interested in maintaining this package, I encourage you to add yourself to meta.maintainers.

Sure, I added myself to the maintainer list. I may also be interested to join the Nixos Java team in the future. For now, I'll try to check in from time to time to https://matrix.to/#/#jvm:nixos.org but probably more as a silent reader if that is ok:smiley:.

[tomodachi94]

Sounds good, thank you ❤️ If you have something to say, feel free to provide input when there's discussion in the channel.

[TomaSajt]

Just saw that this happened, so I quickly threw together an alternative: #359573