maven.buildMavenPackage: support finalAttrs and overrideAttrs #359573
+145
−141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for an alternative to the changes introduced in #313152, which I only noticed when it got merged.
This would not only allow plain
drv.overrideAttrs ...
forbuildMavenPackage
-based packages, but also allow doingbuildMavenPackage (finalAttrs: ...)
Very similar to #354999 and #353526 (it uses the same logic)
The only thing this doesn't currently allow overriding is
mvnFetchExtraArgs
, since it isn't part offinalAttrs
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.