Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.whispers: 2.3.0 -> 2.4.0 #353077

Closed
wants to merge 1 commit into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 2, 2024

Changelog: https://github.com/adeptex/whispers/releases/tag/2.4.0

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 1.severity: blocker This is preventing another PR or issue from being completed label Nov 2, 2024
@fabaff fabaff added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign and removed 1.severity: blocker This is preventing another PR or issue from being completed labels Nov 2, 2024
@fabaff
Copy link
Member Author

fabaff commented Nov 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353077


x86_64-linux

✅ 4 packages built:
  • whispers (python312Packages.whispers)
  • whispers.dist (python312Packages.whispers.dist)
  • swaggerhole
  • swaggerhole.dist

@ofborg ofborg bot added 8.has: clean-up 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 2, 2024
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason this is being disabled on Python < 3.12?

Other comments are just notes for future improvement and IMO don't block getting this in to fix the build.

Comment on lines +56 to +57
jsonschema
jsonschema-specifications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astroid can be removed from the dependency list (since version 2.3.0).

Comment on lines +79 to +82
# AssertionErrors
"test_pairs"
"test_run"
"test_ast_dump"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: track down what's going on with these tests and fix them.

@pbsds
Copy link
Member

pbsds commented Nov 8, 2024

this one works on py311:

The issue was semgrep being in all-packages

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@wegank wegank marked this pull request as draft November 10, 2024 00:46
@fabaff fabaff closed this Nov 17, 2024
@fabaff fabaff deleted the whispers-fix branch November 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants