-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.whispers: 2.3.0 -> 2.4.0 #353077
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason this is being disabled on Python < 3.12?
Other comments are just notes for future improvement and IMO don't block getting this in to fix the build.
jsonschema | ||
jsonschema-specifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
astroid
can be removed from the dependency list (since version 2.3.0).
# AssertionErrors | ||
"test_pairs" | ||
"test_run" | ||
"test_ast_dump" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: track down what's going on with these tests and fix them.
this one works on py311: The issue was semgrep being in all-packages |
Changelog: https://github.com/adeptex/whispers/releases/tag/2.4.0
ZHF: #352882
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.