Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.whispers: add missing deps, unbreak #354501

Merged
merged 2 commits into from
Nov 9, 2024
Merged

python311Packages.whispers: add missing deps, unbreak #354501

merged 2 commits into from
Nov 9, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Nov 8, 2024 •
edited
Loading

This one was a doozy to debug. Simply adding semgrep breaks in python311Packages since semgrep was before only built for python312, and would thus propagate the wrong version of setuptools. Many attemps to make an alias for semgrep-core that points at semgrep.passthru.semgrep-core would either not work for allowAliases=true or allowAliases=false due to missing inputs to callPackage or infinite recursions.

fixes https://hydra.nixos.org/build/276680763
fixes #354317
zhf #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review November 8, 2024 14:28
@nix-owners nix-owners bot requested a review from natsukium November 8, 2024 14:29
@pbsds pbsds force-pushed the fix-whispers-1731071829 branch from 5894fdb to e6ea879 Compare November 8, 2024 14:35
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 8, 2024
@ofborg ofborg bot requested review from 06kellyjac, ambroisie and fabaff November 8, 2024 17:29
@pbsds pbsds force-pushed the fix-whispers-1731071829 branch from e6ea879 to acb3dd9 Compare November 8, 2024 19:50
@pbsds pbsds mentioned this pull request Nov 8, 2024
Closed
13 tasks
@pbsds pbsds requested a review from tjni November 8, 2024 19:55
@pbsbot
Copy link

pbsbot commented Nov 8, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354501

x86_64-linux

✅ 12 packages built:
  • python311Packages.semgrep
  • python311Packages.semgrep.dist
  • python311Packages.whispers
  • python311Packages.whispers.dist
  • semgrep (python312Packages.semgrep)
  • semgrep.dist (python312Packages.semgrep.dist)
  • whispers (python312Packages.whispers)
  • whispers.dist (python312Packages.whispers.dist)
  • route-detect
  • route-detect.dist
  • swaggerhole
  • swaggerhole.dist

tjni
tjni approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@tjni
Copy link
Contributor

tjni commented Nov 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354501

aarch64-darwin

✅ 12 packages built:
  • python311Packages.semgrep
  • python311Packages.semgrep.dist
  • python311Packages.whispers
  • python311Packages.whispers.dist
  • semgrep (python312Packages.semgrep)
  • semgrep.dist (python312Packages.semgrep.dist)
  • whispers (python312Packages.whispers)
  • whispers.dist (python312Packages.whispers.dist)
  • route-detect
  • route-detect.dist
  • swaggerhole
  • swaggerhole.dist

@tjni tjni merged commit 76612b1 into NixOS:master Nov 9, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

@ambroisie ambroisie Awaiting requested review from ambroisie

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.whispers
4 participants
@pbsds @pbsbot @tjni @wegank