Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv: 0.5.6 -> 0.5.7 #362808

Merged
merged 1 commit into from
Dec 8, 2024
Merged

uv: 0.5.6 -> 0.5.7 #362808

merged 1 commit into from
Dec 8, 2024

Conversation

MisileLab
Copy link
Contributor

https://github.com/astral-sh/uv/releases/tag/0.5.7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: misilelab <[email protected]>
@MisileLab
Copy link
Contributor Author

MisileLab commented Dec 8, 2024

@drupol drupol requested a review from GaetanLepage December 8, 2024 16:34
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build uv and uv.tests on all platforms. Thanks :)

@GaetanLepage GaetanLepage merged commit 328fa9f into NixOS:staging-next Dec 8, 2024
19 of 20 checks passed
@MisileLab MisileLab deleted the uv branch December 10, 2024 03:32
@dotlambda
Copy link
Member

No need to target staging(-next) with such a low rebuild count.

@GaetanLepage
Copy link
Contributor

No need to target staging(-next) with such a low rebuild count.

Yes, in general, you are right. However, in this case:

  • Previous updates to uv had been made to staging[-next], so this one couldn't be done on master directly
  • The reason for it is legit: changing uv affects home-assistant and its >1k test packages. I started moving uv update PRs to staging after recommendations by the staging team itself.

@dotlambda
Copy link
Member

  • The reason for it is legit: changing uv affects home-assistant and its >1k test packages. I started moving uv update PRs to staging after recommendations by the staging team itself.

Home Assistant tests are very lightweight. They won't overload Hydra.

@GaetanLepage
Copy link
Contributor

Home Assistant tests are very lightweight. They won't overload Hydra.

Ok good to know. staging people recommended targetting staging at the time. Testing was painful because I was using the US-based ARM builder and it took several hourse because of the transfer times.

@adisbladis
Copy link
Member

The large rebuild count is because of #155060.

@MisileLab
Copy link
Contributor Author

MisileLab commented Dec 12, 2024

  • The reason for it is legit: changing uv affects home-assistant and its >1k test packages. I started moving uv update PRs to staging after recommendations by the staging team itself.

Home Assistant tests are very lightweight. They won't overload Hydra.

I (recommended) target staging(#354450), because large rebuild but also restricted breaking release because of 24.11 release.

@adisbladis adisbladis mentioned this pull request Dec 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants