uv: 0.4.30 -> 0.5.8 #367280
Closed
uv: 0.4.30 -> 0.5.8 #367280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: misilelab <[email protected]>
Signed-off-by: misilelaboratory <[email protected]>
Using `buildPythonPackage` triggers dependency propagation, meaning that using `uv` with `nix-shell` results in a a shell with the `uv` Python input in it. This is problematic for development usage where you only want the one specified version. Often this design bug in the Python package builders is worked around by deleting `$out/nix-support/propagated-build-inputs`, but since `uv` is written in Rust and can be built without a Python interpreter so it's better to just build without a Python interpreter.
This fixes cross builds
Signed-off-by: misilelaboratory <[email protected]>
Signed-off-by: misilelab <[email protected]>
Signed-off-by: misilelab <[email protected]>
adisbladis
force-pushed
the
uv-update-no-staging
branch
from
7be0736 to
00ce0da
Compare
MisileLab
approved these changes
Dec 22, 2024
I targeted |
lucasew
reviewed
Dec 22, 2024
| @@ -47,29 +38,32 @@ python3Packages.buildPythonApplication rec { | |||
| "uv" | |||
| ]; | |||
|
|
|||
| postInstall = '' | |||
| # Tests require python3 | |||
| doCheck = false; | |||
fpletz
approved these changes
Dec 22, 2024
Yes this was the reason. I also agree to target |
GaetanLepage
requested changes
Dec 22, 2024
|
#361878 has been merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
This cherry picks changes done to
uvon staging.Uv updates should never have started going to staging and now that decision keeps leaking in to the
uvupdate workflow.The motivation here is to stop using the staging workflow for uv and go straight to master.
The relatively large rebuild count of
uvis caused by a home-assistant test setup hack, and not a reason to keep targeting staging.See related links for more discussion/complaints:
Note: While 0.5.11 is the latest release 0.5.8 is the latest release that supports rustc <1.83.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.