workflows/eval: Improve debuggabilitiy #364308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes successful workflows trigger that condition, see https://github.com/NixOS/nixpkgs/actions/runs/12278493443/job/34260660227: Comparing against "https://github.com/NixOS/nixpkgs/actions/runs/12278495895" Workflow not done, waiting 10 seconds before checking again Workflow was not successful, cannot make comparison Even though $ gh api /repos/NixOS/nixpkgs/actions/runs/12278495895 --jq .conclusion success Let's print the conclusion when it's not "success" to debug this.
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
nix-owners
bot
requested review from
azuwis,
LeSuisse,
Mic92,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
mweinelt
approved these changes
Dec 11, 2024
|
Just caught this: https://github.com/Infinisil-s-Test-Organization/nixpkgs/actions/runs/12385167025/job/34571123648?pr=37
So we just need to also check that it's not |
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Dec 18, 2024
Sometimes the conclusion is empty when it's still running/pending or so, which needs to be caught, otherwise it can exit preemptively: NixOS#364308 (comment)
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Dec 18, 2024
Sometimes the conclusion is empty when it's still running/pending or so, which needs to be caught, otherwise it can exit preemptively: NixOS#364308 (comment) Co-Authored-By: Reno Dakota <[email protected]>
doronbehar
pushed a commit
to unclechu/nixpkgs
that referenced
this pull request
Dec 22, 2024
Sometimes the conclusion is empty when it's still running/pending or so, which needs to be caught, otherwise it can exit preemptively: NixOS#364308 (comment) Co-Authored-By: Reno Dakota <[email protected]>
getchoo
pushed a commit
to getchoo-contrib/nixpkgs
that referenced
this pull request
Jan 1, 2025
Sometimes the conclusion is empty when it's still running/pending or so, which needs to be caught, otherwise it can exit preemptively: NixOS#364308 (comment) Co-Authored-By: Reno Dakota <[email protected]> (cherry picked from commit 79dca9a)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes successful workflows trigger that condition, see https://github.com/NixOS/nixpkgs/actions/runs/12278493443/job/34260660227:
Even though
Let's print the conclusion when it's not "success" to debug this.
This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.