workflows/eval: Catch empty conclusion #366049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
nix-owners
bot
requested review from
azuwis,
LeSuisse,
Mic92,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
paparodeo
reviewed
Dec 18, 2024
.github/workflows/eval.yml
Outdated
| @@ -165,7 +165,7 @@ jobs: | |||
| runId=$(jq .id <<< "$run") | |||
| conclusion=$(jq -r .conclusion <<< "$run") | |||
|
|
|||
| while [[ "$conclusion" == null ]]; do | |||
| while [[ "$conclusion" == null && "$conclusion" != "" ]]; do | |||
There was a problem hiding this comment.
this looks slightly odd -- perhaps I'm not understanding something but maybe it should be:
Suggested change
| while [[ "$conclusion" == null && "$conclusion" != "" ]]; do | |
| while [[ "$conclusion" == null || "$conclusion" == "" ]]; do |
?
There was a problem hiding this comment.
Oh damn you're right! Embarassing haha
There was a problem hiding this comment.
I thought this was so simple it doesn't even need testing, and still I messed up 😅
Sometimes the conclusion is empty when it's still running/pending or so, which needs to be caught, otherwise it can exit preemptively: NixOS#364308 (comment) Co-Authored-By: Reno Dakota <[email protected]>
infinisil
force-pushed
the
eval-conclusion
branch
from
af5656f to
79dca9a
Compare
paparodeo
approved these changes
Dec 18, 2024
wegank
added
the
12.approvals: 1
|
Git push to origin failed for release-24.11 with exitcode 1 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the conclusion is empty when it's still
running/pending or so, which needs to be caught, otherwise it can exit preemptively: #364308 (comment)
This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.