Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval/tag: remove pull request author from reviewer list #370186

Closed
wants to merge 1 commit into from
Closed

eval/tag: remove pull request author from reviewer list #370186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/eval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ jobs:
# There appears to be no API to request reviews based on GitHub IDs
jq -r 'keys[]' comparison/maintainers.json \
| while read -r id; do gh api /user/"$id"; done \
| jq -s '{ reviewers: map(.login) }' \
| jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login) | map(select(. != $author)) }' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified:

Suggested change
| jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login) | map(select(. != $author)) }' \
| jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login | select(. != $author)) }' \

> reviewers.json

# Request reviewers from maintainers of changed output paths
Expand Down
Loading