Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildPython*: minor changes to prepare for restructuring #378566

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

ShamrockLee
Copy link
Contributor

This PR contains miscellaneous changes to help push #375921.

  • Respect the user's passthru attributes specification. Don't shadow them.
  • Use stdenv.mkDerivation's fixed-point arguments support, and use finalAttrs.finalPackage instead of self whenever appropriate.
  • Apply the assertion to the value it guards. Avoid global assertions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee

This comment was marked as resolved.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and doesn't contain rebuilds.

@ShamrockLee ShamrockLee merged commit 982cfd5 into NixOS:master Feb 2, 2025
24 of 26 checks passed
@ShamrockLee ShamrockLee deleted the build-python-finalAttrs-misc branch February 2, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants