Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildPythonPackage: always export LANG=C.UTF-8 #55826

Closed
wants to merge 420 commits into from
Closed

buildPythonPackage: always export LANG=C.UTF-8 #55826

wants to merge 420 commits into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Feb 15, 2019 •
edited
Loading

Motivation for this change

Now that C.UTF-8 is available, let's use it in Python packages.

#20192

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh added 30 commits February 14, 2019 11:38
@FRidh
python: pamela: 0.3.0 -> 1.0.0
3b54794
@FRidh
python: pamqp: 2.0.0 -> 2.1.0
ab132f4
@FRidh
python: pandas: 0.23.4 -> 0.24.1
e7b173e
@FRidh
python: paperspace: 0.0.13 -> 0.0.15
aa3b14d
@FRidh
python: parameterized: 0.6.1 -> 0.7.0
b4fe2e7
@FRidh
python: parse: 1.9.0 -> 1.11.1
3ea9173
@FRidh
python: parso: 0.3.1 -> 0.3.4
75980d2
@FRidh
python: PasteDeploy: 1.5.2 -> 2.0.1
cd20d50
@FRidh
python: PasteScript: 2.0.2 -> 3.0.0
d53bc99
@FRidh
python: pathos: 0.2.2.1 -> 0.2.3
283795f
@FRidh
python: pbr: 5.1.1 -> 5.1.2
aca40ab
@FRidh
python: pdf2image: 1.3.1 -> 1.4.1
3bbd921
@FRidh
python: pex: 1.5.3 -> 1.6.2
abf0299
@FRidh
python: pg8000: 1.12.4 -> 1.13.1
957a757
@FRidh
python: phonenumbers: 8.10.3 -> 8.10.5
bb2ddd5
@FRidh
python: phonopy: 1.13.2.107 -> 2.0.0
4b49c54
@FRidh
python: pid: 2.2.1 -> 2.2.2
e7b6c04
@FRidh
python: Pillow: 5.3.0 -> 5.4.1
5477e0e
@FRidh
python: pint: 0.8.1 -> 0.9
b573ba7
@FRidh
python: pip-tools: 3.1.0 -> 3.3.2
384e322
@FRidh
python: pip: 18.1 -> 19.0.2
6316fd1
@FRidh
python: pkginfo: 1.4.2 -> 1.5.0.1
194463e
@FRidh
python: plaid-python: 2.3.4 -> 2.4.0
ab6134c
@FRidh
python: plotly: 3.4.2 -> 3.6.1
00a9a5d
@FRidh
python: pluginbase: 0.7 -> 1.0.0
8c780cd
@FRidh
python: plyfile: 0.6 -> 0.7
9c20a19
@FRidh
python: portpicker: 1.2.0 -> 1.3.0
f39d486
@FRidh
python: pox: 0.2.4 -> 0.2.5
cb50e38
@FRidh
python: ppft: 1.6.4.8 -> 1.6.4.9
4886d82
@FRidh
python: premailer: 3.2.0 -> 3.3.0
f3272ea
@FRidh FRidh changed the title buildPythonPackage: always export LANG=UTF-8 buildPythonPackage: always export LANG=C.UTF-8 Feb 15, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog labels Feb 15, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 15, 2019 •
edited
Loading

As I said in #54485 (comment) we also need to support this for the macOS stdenv as well or else we would break macOS support horrible (because C.UTF-8 is not a valid locale there as well). It is probably just a simple patch. However I can not test it, since I don't have access to the hardware/software. If somebody wants to help me out on that, let me know. Also I would move this to stdenv actually since also other application can profit from that.

@FRidh
Copy link
Member Author

FRidh commented Feb 16, 2019

I see, so we're blocked then.

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Feb 16, 2019
@FRidh FRidh force-pushed the python-unstable branch 3 times, most recently from 9a0618e to 9445255 Compare February 17, 2019 13:41
@FRidh FRidh added this to the 19.03 milestone Feb 21, 2019
@FRidh FRidh mentioned this pull request Feb 21, 2019
Open
@FRidh
Copy link
Member Author

FRidh commented Feb 22, 2019

For Darwin we can use the approach as in 8220b5b for now.

@FRidh
Copy link
Member Author

FRidh commented Feb 23, 2019

Included 1fccd25 in staging-next. Cleaning up expressions is for another time.

@FRidh FRidh closed this Feb 23, 2019
This was referenced Mar 19, 2019
Closed
Closed
@bb010g bb010g mentioned this pull request Oct 3, 2020
Closed
@ShamrockLee ShamrockLee mentioned this pull request Feb 20, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation
Projects
None yet
Milestone
19.03
Development

Successfully merging this pull request may close these issues.
5 participants
@FRidh @Mic92 @GrahamcOfBorg @timokau @catern