treewide (Python packages): Use the buildPythonPackage-provide local specification whenever appropriate #383766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
force-pushed
the
python-locale-cleanup
branch
2 times, most recently
from
1072b11 to
287490b
Compare
ShamrockLee
changed the title
ShamrockLee
force-pushed
the
python-locale-cleanup
branch
from
287490b to
db6dcee
Compare
buildPython* already provides global LANG specification. Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
Also remove glibcLocale from nativeBuildInputs, without which the package still builds.
…honApplicaiton Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…honPackage Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…onPackage Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…ythonPackage Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…ackage Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…ackage Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
…Package Also remove glibcLocale from nativeCheckInputs, without which the package still builds.
github-actions
bot
added
10.rebuild-darwin: 5001+
10.rebuild-linux: 5001+
and removed
10.rebuild-linux: 2501-5000
labels
ShamrockLee
force-pushed
the
python-locale-cleanup
branch
from
db6dcee to
9becfac
Compare
ShamrockLee
changed the title
13 tasks
|
Maintainer pings:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the locale specification provided by
buildPythonPackagein commit 1fccd25 whenever appropriate.For packages that requires custom locale settings during installCheckPhase, this PR ensures that they set it back at the end of the phase.
Continuation of #55826
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.