Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Production::inlined: bool flag #323

Closed
OmarTawfik opened this issue Feb 8, 2023 · 0 comments · Fixed by #500
Closed

add Production::inlined: bool flag #323

OmarTawfik opened this issue Feb 8, 2023 · 0 comments · Fixed by #500
Assignees

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Feb 8, 2023

Requirements

  • Prevent it from generating its own RuleKind or TokenKind or ProductionKind.
  • It will behave as if it was inlined into the referencing productions, but without a name.

Missing Validation

  • Parser defs cannot reference inlined Scanner defs.
  • Scanner defs can reference only inlined Scanner defs, except in not: and subtrahend:.
  • Inlined Scanner defs cannot reference top-level Scanner defs.
  • Only Trivia can reference inlined Trivia.
@OmarTawfik OmarTawfik added this to the 0️⃣ Early Prototype milestone Feb 8, 2023
@OmarTawfik OmarTawfik moved this to ⏲ Todo in Slang - 2023 H1 Feb 8, 2023
@AntonyBlakey AntonyBlakey modified the milestones: 1️⃣ Alpha Preview, 2️⃣ Beta Preview Feb 22, 2023
@OmarTawfik OmarTawfik changed the title add Production::inlined: bool field, which will prevent it from generating its own RuleKind or TokenKind add Production::inlined: bool flag Mar 8, 2023
OmarTawfik added a commit that referenced this issue May 19, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
OmarTawfik added a commit that referenced this issue May 22, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
OmarTawfik added a commit that referenced this issue May 23, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
OmarTawfik added a commit that referenced this issue May 23, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
OmarTawfik added a commit that referenced this issue May 24, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be inlined in #323

closes #374
OmarTawfik added a commit that referenced this issue May 24, 2023
Allows us to:

- de-duplicate large operators across different versions
- add names to operators, doing in #353

note: some of the additional nodes (like `ConditionalOperator`) will be
inlined in #323

closes #374
@OmarTawfik OmarTawfik linked a pull request Jun 12, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from ⏲ Todo to ✅ Done in Slang - 2023 H1 Jun 17, 2023
@OmarTawfik OmarTawfik added this to the 1️⃣ Alpha Preview milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants