make sure all named sub-parsers can produce rule kinds #486
Conversation
|
OmarTawfik
force-pushed
the
produce-names-for-all-sub-expressions
branch
3 times, most recently
from
0ac8348 to
b1efa97
Compare
| @@ -42,6 +42,7 @@ pub enum CombinatorNode<'context> { | |||
| primary_expression: &'context CombinatorNode<'context>, | |||
| }, | |||
| Reference { | |||
| name: Option<String>, | |||
There was a problem hiding this comment.
I'm not sure of the use case for renaming references. The referenced tree is already named. I thought this issue was about eliminating the _* names, which would be done by adding names to e.g. repetitions?
There was a problem hiding this comment.
I'm not sure of the use case for renaming references.
The current PR is about #339, which makes sure we can give names to choices + references.
I thought this issue was about eliminating the _* names, which would be done by adding names to e.g. repetitions?
That would be #353, which is still WIP.
For references, it is needed to give names to inlined nodes (that will not generate their own NodeKind). Please check the description of #323 for some examples.
There was a problem hiding this comment.
Will remove the changes to reference and keep choice.
OmarTawfik
force-pushed
the
produce-names-for-all-sub-expressions
branch
from
b1efa97 to
2e35aa7
Compare
|
@AntonyBlakey comment addressed. |
Context: #339 (comment)
add support for naming
choiceparsers, as we can have two nodes of the same kind in succession, and we need to differentiate which is which.Closes #339