Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: NuGet SDK resolver should not throw if project path is NULL #11376

Closed
jeffkl opened this issue Nov 12, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4335
Closed

[Bug]: NuGet SDK resolver should not throw if project path is NULL #11376

jeffkl opened this issue Nov 12, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4335
Assignees
@jeffkl
Labels
Priority:1 High priority issues that must be resolved in the current sprint. Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Type:Bug
Milestone
Sprint 2021-11

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Nov 12, 2021

NuGet Product Used

MSBuild.exe

Product Version

6.0

Worked before?

Yes, 5.x

Impact

It bothers me. A fix would be nice

Repro Steps & Context

MSBuild will evaluate in-memory projects and ask SDK resolvers to resolve paths to SDKs. In previous versions of MSBuild, a context is passed with a null value for the path to the project and the NuGet SDK resolver would throw an exception. However, MSBuild would consider this non-fatal, log a warning, and try the next resolver. In MSBuild 17.0, this logic changed to consider this scenario fatal and fail evaluation.

Related: dotnet/msbuild#7035

Verbose Logs

No response
@jeffkl jeffkl added Type:Bug Triage:Untriaged Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team and removed Triage:Untriaged labels Nov 12, 2021
@jeffkl jeffkl self-assigned this Nov 12, 2021
@jeffkl jeffkl mentioned this issue Nov 15, 2021
Merged
8 tasks
@jeffkl jeffkl added the Priority:1 High priority issues that must be resolved in the current sprint. label Nov 15, 2021
@jeffkl jeffkl added this to the Sprint 2021-11 milestone Nov 15, 2021
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue Nov 16, 2021
@jeffkl
Fix ArgumentNullException when SDK resolver is given a null project path
d84f713 
Fixes NuGet/Home#11376
@benvillalobos benvillalobos mentioned this issue Nov 18, 2021
Closed
@jeffkl jeffkl mentioned this issue Nov 18, 2021
Closed
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue Nov 20, 2021
@jeffkl
Fix ArgumentNullException when SDK resolver is given a null project path
cecee79 
Fixes NuGet/Home#11376
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue Nov 22, 2021
@jeffkl
Fix ArgumentNullException when SDK resolver is given a null project p…
3d44676 
…ath (#4335)

Fixes NuGet/Home#11376
@leonardochaia leonardochaia mentioned this issue Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Priority:1 High priority issues that must be resolved in the current sprint. Product:MSBuildSDKResolver The NuGet powered SDK resolver. Owned by MSBuild team Type:Bug
Projects
None yet
Milestone
Sprint 2021-11
Development

Successfully merging a pull request may close this issue.

Fix ArgumentNullException when SDK resolver is given a null project path NuGet/NuGet.Client
1 participant
@jeffkl