Fix ArgumentNullException when SDK resolver is given a null project path #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
approved these changes
Nov 15, 2021
erdembayar
approved these changes
Nov 15, 2021
zivkan
approved these changes
Nov 16, 2021
jeffkl
force-pushed
the
dev-jeffkl-fix-sdkresolver-nullref
branch
2 times, most recently
from
d84f713 to
eefe876
Compare
jeffkl
force-pushed
the
dev-jeffkl-fix-sdkresolver-nullref
branch
from
eefe876 to
0395cf1
Compare
jeffkl
force-pushed
the
dev-jeffkl-fix-sdkresolver-nullref
branch
from
ba8d9f4 to
cecee79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11376
Regression? No Last working version:
Description
The SDK resolver has never handled a null project path before but a recent behavior change in MSBuild (#6763) has made this a fatal error.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation