Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NETCore file new project should block the build during restore #3780

Closed
emgarten opened this issue Oct 26, 2016 · 1 comment
Closed

.NETCore file new project should block the build during restore #3780

emgarten opened this issue Oct 26, 2016 · 1 comment
Assignees
@alpaix
Labels
Functionality:Restore Platform:Xplat Style:PackageReference Type:Bug
Milestone
4.0 RC

Comments

@emgarten
Copy link
Member

It should not be possible to start a build while a project is restoring.

Steps

  1. File New Project > Web > NETCore
  2. While restore is still running start a build

Expected

The build button should not be enabled while restore is running

Actual

A build starts
@rrelyea rrelyea added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Oct 26, 2016
@rrelyea rrelyea added this to the 4.0 RC milestone Oct 27, 2016
@rrelyea rrelyea self-assigned this Oct 27, 2016
@rrelyea rrelyea added Type:Bug Resolution:External This issue appears to be External to nuget and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Oct 27, 2016
@rrelyea
Copy link
Contributor

rrelyea commented Oct 27, 2016

We are working with CPS team to get this to happen

@natidea natidea mentioned this issue Oct 28, 2016
Closed
@alpaix alpaix mentioned this issue Oct 31, 2016
Merged
@rrelyea rrelyea assigned alpaix and unassigned rrelyea Nov 1, 2016
alpaix added a commit to alpaix/NuGet.Client that referenced this issue Nov 1, 2016
@alpaix
Return restore task on nomination
baa081a 
Resolves NuGet/Home#3780.

`NominateProjectAsync` returns a restore task CPS will use to block
the build by setting it as a critical task.

This change complies with the original design depicted in the
[spec](https://github.com/NuGet/Home/wiki/NuGet-Restore-Manager).
@alpaix alpaix mentioned this issue Nov 1, 2016
Merged
emgarten pushed a commit to NuGet/NuGet.Client that referenced this issue Nov 2, 2016
@alpaix @emgarten
Return restore task on nomination
6eacc01 
Resolves NuGet/Home#3780.

`NominateProjectAsync` returns a restore task CPS will use to block
the build by setting it as a critical task.

This change complies with the original design depicted in the
[spec](https://github.com/NuGet/Home/wiki/NuGet-Restore-Manager).
@rrelyea rrelyea reopened this Nov 3, 2016
@rrelyea rrelyea closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpaix alpaix

Labels
Functionality:Restore Platform:Xplat Style:PackageReference Type:Bug
Projects
None yet
Milestone
4.0 RC
Development

No branches or pull requests
4 participants
@emgarten @alpaix @rrelyea and others