Return restore task on nomination #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves NuGet/Home#3780. `NominateProjectAsync` returns a restore task CPS will use to block the build by setting it as a critical task. This change complies with the original design depicted in the [spec](https://github.com/NuGet/Home/wiki/NuGet-Restore-Manager).
|
CPS side effort to support blocking build on restore is in review dotnet/project-system#685. |
emgarten
approved these changes
Nov 1, 2016
natidea
reviewed
Nov 1, 2016
| @@ -111,12 +111,11 @@ public sealed class VsSolutionRestoreService : IVsSolutionRestoreService | |||
| _projectSystemCache.AddProjectRestoreInfo(projectNames, packageSpec); | |||
|
|
|||
| // returned task completes when scheduled restore operation completes. | |||
| // it should be discarded as we don't want to block CPS on that. | |||
| var ignored = _restoreWorker.ScheduleRestoreAsync( | |||
| var restoreTask = _restoreWorker.ScheduleRestoreAsync( | |||
There was a problem hiding this comment.
So the restoreTask returned is the same when two nominate call are made without a restore between them?
|
LGTM |
jainaashish
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NuGet/Home#3780.
NominateProjectAsyncreturns a restore task CPS will use to blockthe build by setting it as a critical task.
This change complies with the original design depicted in the
spec.
//cc @emgarten @jainaashish @joelverhagen @mishra14 @rrelyea