Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging (via status bar, output window, and warning/error window) requires UI thread and slows down Restore greatly. #4640

Closed
rrelyea opened this issue Feb 17, 2017 · 1 comment
Assignees
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Tenet:Performance Performance issues Type:Bug
Milestone

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Feb 17, 2017

Split off from #4617

@rrelyea rrelyea added Tenet:Performance Performance issues Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug labels Feb 17, 2017
@rrelyea rrelyea added this to the 2.14 milestone Feb 17, 2017
@rrelyea rrelyea modified the milestones: 4.0 RTM, 2.14 Feb 17, 2017
@DoRonMotter DoRonMotter modified the milestones: 4.0.1, 4.0 RTM Feb 24, 2017
@emgarten emgarten modified the milestones: 4.1, Future-0 Mar 6, 2017
@emgarten
Copy link
Member

emgarten commented Mar 9, 2017

Logging and error list improvements

  • Moves from the legacy TaskProvider error list to the free threaded IErrorList
  • Warnings/errors are no longer logged from the UI thread
  • Optimized logging to only move to the UI thread when needed, this shows a 3x perf improvement in some scenarios

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Mar 9, 2017
* Moves from the legacy TaskProvider error list to the free threaded IErrorList
* Warnings/errors are no longer logged from the UI thread
* Optimized logging to only move to the UI thread when needed, this shows a 3x perf improvement in some scenarios
* Restore no longer clears warnings/errors from other parts of Visual Studio

Fixes NuGet/Home#4640
Fixes NuGet/Home#4774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Development

No branches or pull requests

3 participants