Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore clears warnings/errors from build #4774

Closed
emgarten opened this issue Mar 9, 2017 · 1 comment
Closed

Restore clears warnings/errors from build #4774

emgarten opened this issue Mar 9, 2017 · 1 comment
Assignees
Milestone

Comments

@emgarten
Copy link
Member

emgarten commented Mar 9, 2017

Actual:
Restore clears warnings and errors in the error list logged by build and other extensions.

Expected:
Restore only clears NuGet related warnings/errors.

@emgarten emgarten added this to the 4.1 milestone Mar 9, 2017
@emgarten emgarten self-assigned this Mar 9, 2017
@emgarten
Copy link
Member Author

emgarten commented Mar 9, 2017

This has been fixed as part of the move to IErrorList, the client now has better control over errors and warnings in the list.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Mar 9, 2017
* Moves from the legacy TaskProvider error list to the free threaded IErrorList
* Warnings/errors are no longer logged from the UI thread
* Optimized logging to only move to the UI thread when needed, this shows a 3x perf improvement in some scenarios
* Restore no longer clears warnings/errors from other parts of Visual Studio

Fixes NuGet/Home#4640
Fixes NuGet/Home#4774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant