Consider AssetTargetFallback when selecting transitive project/package dependencies #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
force-pushed
the
dev-nkolev92-atfForDeps
branch
from
77ab174 to
80b7bdb
Compare
nkolev92
force-pushed
the
dev-nkolev92-atfForDeps
branch
from
80b7bdb to
ba6d660
Compare
zivkan
approved these changes
Jan 28, 2022
This was referenced Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#5957
Regression? Last working version:
Description
Read design at: https://github.com/NuGet/Home/blob/dev/proposed/2022/AssetTargetFallback-DependenciesResolution.md.
Account for ATF when checking dependencies. There's no new warning being raised if ATF is being used for dependencies.
Note that there's 2 places where these changes are applied, both for Package and project references, SourceRepositoryDependencyProvider and PackageSpecReferenceDependencyProvider respectively.
The ATF warnings in the project reference case are raised by MSBuild calling into https://github.com/NuGet/NuGet.Client/blob/0ca13dff1ebdd33c2f20a66aa059628200a16af9/src/NuGet.Core/NuGet.Build.Tasks/GetReferenceNearestTargetFrameworkTask.cs.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation