Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents to net6.… #59324

Merged
merged 1 commit into from
Feb 6, 2022
Merged

move Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents to net6.… #59324

merged 1 commit into from
Feb 6, 2022

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Feb 6, 2022

…0-windows

this appears to be an error. the tests for this assembly target net6.0-windows

@jmarolf
move Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents to net6.…
0250924 
…0-windows

this appears to be an error. the tests for this assembly target net6.0-windows
@jmarolf jmarolf requested a review from a team as a code owner February 6, 2022 18:48
CyrusNajmabadi
CyrusNajmabadi approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this isn't a problem in CI?

@jmarolf
Copy link
Contributor Author

jmarolf commented Feb 6, 2022 •
edited
Loading

How come this isn't a problem in CI?

CI does not use un-released versions of nuget. we build and restore against SDK 6.0.100. The place where this breaking change was introduced (NuGet/NuGet.Client#4372) only exists in internal builds of Visual Studio and the .NET SDK. If you are on a public preview build of Visual Studio you are safe. Though eventually this would break CI when we updated our images or the version of the .NET SDK we used

@jmarolf jmarolf closed this Feb 6, 2022
@jmarolf jmarolf reopened this Feb 6, 2022
@jmarolf jmarolf merged commit b7478c4 into dotnet:main Feb 6, 2022
@jmarolf jmarolf deleted the infrastructure/migrate-Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents-to-net6.0-windows branch February 6, 2022 23:10
@ghost ghost added this to the Next milestone Feb 6, 2022
JoeRobich
JoeRobich reviewed Feb 6, 2022
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dibarbet dibarbet mentioned this pull request Feb 7, 2022
Closed
sharwell added a commit to sharwell/roslyn that referenced this pull request Feb 7, 2022
@sharwell
Revert "Merge pull request dotnet#59324 from jmarolf/infrastructure/m…
5b08fc2 
…igrate-Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents-to-net6.0-windows"

This reverts commit b7478c4, reversing
changes made to be221d5.
@sharwell sharwell mentioned this pull request Feb 7, 2022
Merged
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jmarolf @JoeRobich @CyrusNajmabadi @RikkiGibson