Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Live #3338

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Publish Live #3338

merged 4 commits into from
Sep 10, 2024

Conversation

Mikejo5000
Copy link
Contributor

No description provided.

@Mikejo5000 Mikejo5000 requested review from a team as code owners September 10, 2024 19:24
Copy link

Learn Build status updates of commit 50aa4c8:

💡 Validation status: suggestions

File Status Preview URL Details
docs/reference/Errors-and-Warnings.md 💡Suggestion View Details
docs/concepts/Auditing-Packages.md ✅Succeeded View
docs/nuget-org/media/nuget-org-permissions.png ✅Succeeded View
docs/nuget-org/media/nuget-org-register-2fa.png ✅Succeeded n/a (file deleted or renamed)
docs/nuget-org/media/nuget-org-register.png ✅Succeeded View
docs/nuget-org/media/unmanaged-aad-tenant.png ✅Succeeded View
docs/reference/errors-and-warnings/NU1508.md ✅Succeeded View
docs/reference/errors-and-warnings/NU1901-NU1904.md ✅Succeeded View
docs/reference/media/registered-certs.png ✅Succeeded View
docs/reference/nuget-config-file.md ✅Succeeded View
docs/release-notes/NuGet-6.12.md ✅Succeeded View
docs/TOC.md ✅Succeeded View

docs/reference/Errors-and-Warnings.md

  • Line 28, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Mikejo5000
Copy link
Contributor Author

@zivkan Andy, are your changes OK to publish live?

Copy link
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are your changes OK to publish live

yes. Frankly I don't understand the purpose of having separate live and main branches. If we wanted to stage changes until a particular time, we could have used a feature branch 🤷

I feel like the different live & main branches unnecessarily delays useful docs updates.

@Mikejo5000 Mikejo5000 merged commit b5c9645 into live Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants