[MIG] hr_employee_firstname: Migration to 16.0 #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove ensure one * Add decorator * Update name on write and update related partner firstname lastname * Modify README file * Change version format * Consistency with partner_firstname module * Check if the partner isn't already in the list * Remove check on partner_firstname installation
… value not the key of dict (OCA#215) * Update split names at module install to get the value not the key of the dict. * Add test for checking right values in firstname, lastname after install
This issue was flagged by travis in the following build https://travis-ci.org/OCA/hr/jobs/364219109
Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/fa/
Currently translated at 100.0% (3 of 3 strings) Translation: hr-11.0/hr-11.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_employee_firstname/de/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/es/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/de/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_firstname/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-14.0/hr-14.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_firstname/pt_BR/
Currently translated at 60.0% (6 of 10 strings) Translation: hr-14.0/hr-14.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_firstname/ca/
Starting from 14.0, employee model was split into three models: - `hr.employee.public` - `hr.employee.private` - `hr.employee` (a common model) When this module was migrated, such split was not taken into account. This commit moves fields to the common model, so they don't fail when read from the public employee model. Closes OCA#990 Co-Authored-By: Luis González <[email protected]>
Currently translated at 100.0% (11 of 11 strings) Translation: hr-14.0/hr-14.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_firstname/de/
Currently translated at 54.5% (6 of 11 strings) Translation: hr-15.0/hr-15.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_firstname/pt_BR/
Currently translated at 63.6% (7 of 11 strings) Translation: hr-15.0/hr-15.0-hr_employee_firstname Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_firstname/pt_BR/
luistorresm
force-pushed
the
16.0-hr_employee_firstname-luist
branch
from
de11d76 to
d95b219
Compare
hugho-ad
approved these changes
Nov 5, 2022
|
Unittests passing well and tested functionally: So, I think we can merge it |
|
/ocabot merge nobump |
nimarosa
approved these changes
Nov 5, 2022
etobella
approved these changes
Nov 5, 2022
|
I think ocabot had some issue here... /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c5736da. Thanks a lot for contributing to OCA. ❤️ |
|
/ocabot migration hr_employee_firstname |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.