-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve extension number on merge #26
Comments
I think we could quickly rewrite history and change |
+1 to "no holes" and changing |
@pwinckles we discussed adding language to the merge policy that says something like: extensions should remain |
Yep, that sounds good to me |
Resolves: #26 Co-authored-by: Andrew Woods <[email protected]>
Perhaps the merge policy should be updated to specify that an extension's number should be resolved immediately prior to merging. For example, PR #20 was just merged, creating extension
0006-flat-direct-storage-layout
. Now there is a gap in the merged extensions. This gap will be filled if all of the existing PR merged, but will leave holes if they are not.So, I guess the question is, are we okay with holes? If so, extensions claiming the next available number when their PR is submitted is fine. If not, we should update the extension number immediately before merging.
The text was updated successfully, but these errors were encountered: