Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve extension number on merge #26

Closed
pwinckles opened this issue Sep 9, 2020 · 4 comments · Fixed by #35
Closed

Resolve extension number on merge #26

pwinckles opened this issue Sep 9, 2020 · 4 comments · Fixed by #35
Assignees

Comments

@pwinckles
Copy link
Contributor

Perhaps the merge policy should be updated to specify that an extension's number should be resolved immediately prior to merging. For example, PR #20 was just merged, creating extension 0006-flat-direct-storage-layout. Now there is a gap in the merged extensions. This gap will be filled if all of the existing PR merged, but will leave holes if they are not.

So, I guess the question is, are we okay with holes? If so, extensions claiming the next available number when their PR is submitted is fine. If not, we should update the extension number immediately before merging.

@zimeon
Copy link
Contributor

zimeon commented Sep 9, 2020

I think we could quickly rewrite history and change 0006-flat-direct-storage-layout to 0002-flat-direct-storage-layout then adopt the policy that @pwinckles propses -- I think it would be best not to create holes

@awoods
Copy link
Member

awoods commented Sep 9, 2020

+1 to "no holes" and changing 0006-flat-direct-storage-layout to 0002-flat-direct-storage-layout.

@rosy1280
Copy link
Contributor

@pwinckles we discussed adding language to the merge policy that says something like: extensions should remain nnnn and then before merge an editor will update the PR to include the appropriate extension number. thoughts?

@pwinckles
Copy link
Contributor Author

@pwinckles we discussed adding language to the merge policy that says something like: extensions should remain nnnn and then before merge an editor will update the PR to include the appropriate extension number. thoughts?

Yep, that sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants