Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flat storage layout #20

Merged
merged 4 commits into from
Sep 9, 2020
Merged

flat storage layout #20

merged 4 commits into from
Sep 9, 2020

Conversation

pwinckles
Copy link
Contributor

Flat storage layout extension that maps object ids directly to directory names. This extension has limited value outside of test use cases.

@rosy1280 rosy1280 added the draft label Aug 18, 2020
@pwinckles pwinckles added in-review and removed draft labels Aug 18, 2020
@pwinckles pwinckles changed the title initial draft for a flat storage layout flat storage layout Aug 18, 2020
docs/0006-flat-layout.md Outdated Show resolved Hide resolved
docs/0006-flat-layout.md Outdated Show resolved Hide resolved
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment... otherwise, looks good.


* The size of object IDs cannot exceed the maximum allowed directory name size (eg. 255 characters)
* Object IDs cannot include characters that are illegal in directory names
* Performance may degrade as the size of a repository increases because every object is a direct children of the storage root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo/grammar: "...every object is a direct children of..." should be "...every object is a direct child of..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/0006-flat-layout.md Outdated Show resolved Hide resolved
@rosy1280 rosy1280 merged commit d51afc5 into OCFL:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants