Replicate specification of Object extension into Storage Root extensi… #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons section Resolves: #557
pwinckles
reviewed
Apr 7, 2022
| sub-directories other than extension sub-directories. Extension sub-directories | ||
| <span id="W016">SHOULD</span> be named according to a <a>registered extension name</a>. The specific | ||
| structure and function of the extension, as well as a declaration of the registered extension name | ||
| <span id="E113">MUST</span> be defined in one of the following locations: |
There was a problem hiding this comment.
Personally, I would not include E113. It is impossible to enforce.
There was a problem hiding this comment.
I agree that we should drop E113 -- the "structure and function part" is not enforceable, and the notion of it being a registered name overlaps with the warning W016. (This also applies in the object extensions section for E068 and W013.)
There was a problem hiding this comment.
I note this has tons of overlap with #565, will propose approach there. I think we could move forward with this PR (addressing the replication issue alone) by simply removing the text from the E113 sentence onward.
10 tasks
14 tasks
|
Superseded by: #607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ons section
Resolves: #557