Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate specification of Object extension section #607

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Conversation

awoods
Copy link
Member

@awoods awoods commented Jun 22, 2022

This update replicates the Object extension specification text from Object extension into Storage Root extension

Resolves: #557

Supersedes: #583

This update replicates the Object extension specification text from Object extension into Storage Root extension

Resolves: #557

Supersedes: #583
Copy link
Contributor

@rosy1280 rosy1280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awoods leaving a comment because i'm not sure this is a hold up for approval. would rather others weight in.

the purposes of extending the functionality of an OCFL Storage Root. The guidelines and limitations for the storage
root `extensions` directory are defined in alignment with those of the [object extensions](#object-extensions).

The `extensions` directory <span id="E112" class="rfc2119">MUST NOT</span> contain any files, and no sub-directories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is awkward. Why not:

The extensions directory MUST NOT contain any files or subdirectories other than extension subdirectories...

other than extension sub-directories. Extension sub-directories <span id="W016" class="rfc2119">SHOULD</span> be named
according to a <a>registered extension name</a>.

> Non-normative note: Extension sub-directories should use the same name as a registered extension in order to both
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run the two non-normative notes (this and the existing one that follows) into one? I.e. put a > for the blank line between paras and remove the second "Non-normative note: "

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(otherwise looks good)

@julianmorley julianmorley merged commit a60891a into main Jun 23, 2022
@julianmorley julianmorley deleted the issue-557c branch June 23, 2022 07:15
rosy1280 added a commit that referenced this pull request Jun 23, 2022
changes this to match other language changes in PR #607
julianmorley pushed a commit that referenced this pull request Jun 24, 2022
changes this to match other language changes in PR #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve description of storage root extensions
5 participants