Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2964 #2981

Closed
wants to merge 2 commits into from
Closed

Fix 2964 #2981

wants to merge 2 commits into from

Conversation

GitanjaliChhetri
Copy link

Fixes #2964

Fix summary:
Update the error message for segmentation load failure due to orientation tolerance value.
Direct user to change the tolerance value under Segmentation settings.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #2981 (dc55822) into master (fe57c00) will decrease coverage by 0.75%.
The diff coverage is 2.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
- Coverage   12.68%   11.92%   -0.76%     
==========================================
  Files         306      307       +1     
  Lines        8233     8451     +218     
  Branches     1593     1682      +89     
==========================================
- Hits         1044     1008      -36     
- Misses       5797     5953     +156     
- Partials     1392     1490      +98     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.66% <0.00%> (-0.73%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
.../DICOMSR/SCOORD3D/utils/getReferencedImagesList.js 0.00% <0.00%> (-7.15%) ⬇️
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
...orm/core/src/DICOMSR/parseDicomStructuredReport.js 7.50% <0.00%> (-1.60%) ⬇️
platform/core/src/classes/HotkeysManager.js 76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aba01f...dc55822. Read the comment docs.

@GitanjaliChhetri
Copy link
Author

Discarding this in favor of #2982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDC: change message for segmentation when it fails to load because of orientation to
1 participant