fix: #2964 Update message for segmentation error loading due to orien…

[GitanjaliChhetri]

Fixes #2964

Fix summary:
Update the error message for segmentation load failure due to orientation tolerance value.
Direct user to change the tolerance value under Segmentation settings.

[codecov]

Codecov Report

Merging #2982 (845e2a5) into master (fe57c00) will decrease coverage by 0.74%.
The diff coverage is 2.08%.

@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
- Coverage   12.68%   11.93%   -0.75%     
==========================================
  Files         306      307       +1     
  Lines        8233     8451     +218     
  Branches     1593     1680      +87     
==========================================
- Hits         1044     1009      -35     
- Misses       5797     5954     +157     
- Partials     1392     1488      +96     

Impacted Files	Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js	2.63% <0.00%> (-0.76%)	⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js	5.40% <ø> (ø)
.../DICOMSR/SCOORD3D/utils/getReferencedImagesList.js	6.25% <0.00%> (-0.90%)	⬇️
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js	1.72% <0.00%> (-0.07%)	⬇️
...orm/core/src/DICOMSR/parseDicomStructuredReport.js	7.50% <0.00%> (-1.60%)	⬇️
platform/core/src/classes/HotkeysManager.js	76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js	1.03% <0.00%> (+0.01%)	⬆️
...latform/core/src/classes/metadata/StudyMetadata.js	1.25% <0.00%> (-0.04%)	⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js	50.00% <0.00%> (ø)
.../src/studies/services/wado/studyInstanceHelpers.js	1.56% <0.00%> (-0.48%)	⬇️
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa423c...845e2a5. Read the comment docs.

[igoroctaviano]

Hi @GitanjaliChhetri. Thanks for your contribution.
The error message LGTM. Before moving forward I have some questions:

1. Do we want to display this information next to the thumbnail as an inconsistency warning as well? (when you hover the thumbnail warning icon)
2. I think we can add this error message only in the dicom-segmentation extension since this is a segmentation-specific error message, right? there's any other case why this would not be enough?

[GitanjaliChhetri]

Thanks, @igoroctaviano !

1. We already display the inconsistency warning in the thumbnail. The warning message in the thumbnail is the original message from dcmjs. Please refer the picture.
   

2. The modified message aims at redirecting the user to segmentation panel settings in order to support viewing of segmentations that are detected as non-planar due to the 32 bit float rounding error (for example, for segmentations converted from nii to dcm, original issue here Segmentations converted from nii to dcm not rendered in OHIF Viewer #2869 (comment)) .
   Since dcmjs is an external library, I think we are good keeping this modified message containing information about the UI of the upper level App within OHIF.

[igoroctaviano]

LGTM