-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re IDC #3077: Seg series thumbnail selection #3078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3078 +/- ##
==========================================
- Coverage 12.68% 11.94% -0.74%
==========================================
Files 306 306
Lines 8233 8437 +204
Branches 1593 1678 +85
==========================================
- Hits 1044 1008 -36
- Misses 5797 5943 +146
- Partials 1392 1486 +94
Continue to review full report at Codecov.
|
9696d63
to
dfa3db8
Compare
OHIF.Viewer.-.Google.Chrome.2023-01-12.00-43-11.mp4OHIF.Viewer.-.Google.Chrome.2023-01-12.00-38-11.mp4 |
Fix for the other two bugs: OHIF.Viewer.-.Google.Chrome.2023-01-12.01-56-29.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just left one comment but it's your call. Feel free to merge it if there's nothing there to be changed.
extensions/dicom-segmentation/src/components/SegmentationSettings/SegmentationSettings.js
Outdated
Show resolved
Hide resolved
* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance (OHIF#3017) * chore(release): publish [skip ci] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] * Re IDC OHIF#3067: Show eye-icon when segment label name is long (OHIF#3073) * fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance * fix: Show eye-icon when segment name is long * update python version * chore(release): publish [skip ci] - @ohif/[email protected] - @ohif/[email protected] * Re IDC OHIF#3047: update variable name for frame index (OHIF#3085) * chore(release): publish [skip ci] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] - @ohif/[email protected] * Re IDC OHIF#3088: Fix seg toggle visibility logic (OHIF#3101) * chore(release): publish [skip ci] - @ohif/[email protected] - @ohif/[email protected] * chore: update issue and PR templates (OHIF#3113) * chore: update issue templates * add template to PRs * update for pr titles * update * update * update description * Re IDC OHIF#3077: Seg series thumbnail selection (OHIF#3078) * fix: OHIF#3077 update seg tolerance popup and update seg thumbnail warning * jump to first segment item image * Shows warning message only once on onChange * chore(release): publish [skip ci] - @ohif/[email protected] - @ohif/[email protected] * fix crashing of large files * remove fix * remove unused import --------- Co-authored-by: Gitanjali <[email protected]> Co-authored-by: ohif-bot <[email protected]> Co-authored-by: Alireza <[email protected]>
PR Checklist
@mention
a maintainer to request a reviewFixes: #3077