Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re IDC #3077: Seg series thumbnail selection #3078

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

GitanjaliChhetri
Copy link

@GitanjaliChhetri GitanjaliChhetri commented Dec 15, 2022

PR Checklist

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review

Fixes: #3077

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #3078 (0c3a379) into master (fe57c00) will decrease coverage by 0.73%.
The diff coverage is 2.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   12.68%   11.94%   -0.74%     
==========================================
  Files         306      306              
  Lines        8233     8437     +204     
  Branches     1593     1678      +85     
==========================================
- Hits         1044     1008      -36     
- Misses       5797     5943     +146     
- Partials     1392     1486      +94     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.66% <0.00%> (-0.73%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
...orm/core/src/DICOMSR/parseDicomStructuredReport.js 7.50% <0.00%> (-1.60%) ⬇️
platform/core/src/classes/HotkeysManager.js 76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
...udies/services/wado/getReferencedSeriesSequence.js 7.69% <0.00%> (-0.65%) ⬇️
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9aa6a...0c3a379. Read the comment docs.

@GitanjaliChhetri
Copy link
Author

OHIF.Viewer.-.Google.Chrome.2023-01-12.00-43-11.mp4
OHIF.Viewer.-.Google.Chrome.2023-01-12.00-38-11.mp4

@GitanjaliChhetri
Copy link
Author

Fix for the other two bugs:
Show segmentation tolerance changed notification message only once after setting to a new value.
Update thumbnail inconsistency warning for seg series after modifying segmentation tolerance value.

OHIF.Viewer.-.Google.Chrome.2023-01-12.01-56-29.mp4

@GitanjaliChhetri GitanjaliChhetri changed the title fix: #3077 update seg tolerance popup and update seg thumbnail warning ReIDC #3077: Seg series thumbnail selection Jan 12, 2023
@GitanjaliChhetri GitanjaliChhetri changed the title ReIDC #3077: Seg series thumbnail selection Re IDC #3077: Seg series thumbnail selection Jan 12, 2023
@GitanjaliChhetri GitanjaliChhetri marked this pull request as ready for review January 12, 2023 15:12
Copy link
Contributor

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left one comment but it's your call. Feel free to merge it if there's nothing there to be changed.

@GitanjaliChhetri GitanjaliChhetri merged commit 24bbf2b into OHIF:master Jan 17, 2023
justvamp pushed a commit to MDWio/ohif-viewer that referenced this pull request Mar 2, 2023
* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance (OHIF#3017)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3067: Show eye-icon when segment label name is long (OHIF#3073)

* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance

* fix: Show eye-icon when segment name is long

* update python version

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3047: update variable name for frame index (OHIF#3085)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3088: Fix seg toggle visibility logic (OHIF#3101)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* chore: update issue and PR templates (OHIF#3113)

* chore: update issue templates

* add template to PRs

* update for pr titles

* update

* update

* update description

* Re IDC OHIF#3077: Seg series thumbnail selection (OHIF#3078)

* fix: OHIF#3077 update seg tolerance popup and update seg thumbnail warning

* jump to first segment item image

* Shows warning message only once on onChange

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* fix crashing of large files

* remove fix

* remove unused import

---------

Co-authored-by: Gitanjali <[email protected]>
Co-authored-by: ohif-bot <[email protected]>
Co-authored-by: Alireza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEG series selection from the leftside panel does not jump to the image with the first segment
2 participants